Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 10919146: Get rid of a lot of () for getters. (Closed)

Created:
8 years, 3 months ago by kasperl
Modified:
8 years, 3 months ago
Reviewers:
bakster
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get rid of a lot of () for getters. R=bak@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4268 lines, -4268 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/GettersSettersTest.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/testsource/NamingTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/test_data/SampleCode/sampler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/constant_system.dart View 1 chunk +22 lines, -22 lines 0 comments Download
M lib/compiler/implementation/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/js_backend/constant_system_javascript.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/js_backend/emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/coreimpl_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/lib/isolate_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/byte_strings.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/token.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/ssa/optimize.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/typechecker.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/core/collection.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/date.dart View 3 chunks +12 lines, -12 lines 0 comments Download
M lib/core/exceptions.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/future.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M lib/core/map.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/options.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/core/string.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/string_buffer.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/coreimpl/date.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M lib/coreimpl/duration_implementation.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M lib/coreimpl/future_implementation.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M lib/coreimpl/hash_map_set.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/coreimpl/linked_hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/coreimpl/options.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/coreimpl/queue.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/coreimpl/regexp.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/coreimpl/splay_tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/coreimpl/string_buffer.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/crypto/crypto.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/crypto/crypto_vm.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/crypto/hash_utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/src/DOMType.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/src/GlobalProperties.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/dom/src/dart2js_DOMImplementation.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M lib/dom/src/dart2js_DOMType.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/src/dummy_GlobalProperties.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/dom/src/native_DOMImplementation.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/dom/src/native_DOMPublic.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 507 chunks +1518 lines, -1518 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 509 chunks +1501 lines, -1501 lines 0 comments Download
M lib/html/src/AnimationEvent.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/html/src/AnimationEventWrappingImplementation.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/html/src/BeforeLoadEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/BeforeLoadEventWrappingImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/CloseEvent.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/src/CloseEventWrappingImplementation.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/src/CompositionEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/CompositionEventWrappingImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/CssClassSet.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/CustomEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/CustomEventWrappingImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/DataAttributeMap.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/Device.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M lib/html/src/DeviceMotionEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/DeviceMotionEventWrappingImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/DeviceOrientationEvent.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/src/DeviceOrientationEventWrappingImplementation.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/src/DocumentFragmentWrappingImplementation.dart View 8 chunks +31 lines, -31 lines 0 comments Download
M lib/html/src/ErrorEvent.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/src/ErrorEventWrappingImplementation.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/src/HashChangeEvent.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/html/src/HashChangeEventWrappingImplementation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/html/src/KeyboardEvent.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M lib/html/src/KeyboardEventWrappingImplementation.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M lib/html/src/MessageEvent.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M lib/html/src/MessageEventWrappingImplementation.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M lib/html/src/MutationEvent.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M lib/html/src/MutationEventWrappingImplementation.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M lib/html/src/OverflowEvent.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/src/OverflowEventWrappingImplementation.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/src/PageTransitionEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/PageTransitionEventWrappingImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/PopStateEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/PopStateEventWrappingImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/ProgressEvent.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/src/ProgressEventWrappingImplementation.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/html/src/SVGElement.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M lib/html/src/SVGElementInstance.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M lib/html/src/SVGElementInstanceWrappingImplementation.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M lib/html/src/SVGElementWrappingImplementation.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M lib/html/src/SVGSVGElement.dart View 1 chunk +14 lines, -14 lines 0 comments Download
M lib/html/src/SVGSVGElementWrappingImplementation.dart View 5 chunks +27 lines, -27 lines 0 comments Download
M lib/html/src/StorageEvent.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M lib/html/src/StorageEventWrappingImplementation.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M lib/html/src/TextEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/TextEventWrappingImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/TouchEvent.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M lib/html/src/TouchEventWrappingImplementation.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M lib/html/src/TransitionEvent.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/html/src/TransitionEventWrappingImplementation.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/html/src/UIEvent.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M lib/html/src/UIEventWrappingImplementation.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M lib/html/src/WheelEvent.dart View 1 chunk +15 lines, -15 lines 0 comments Download
M lib/html/src/WheelEventWrappingImplementation.dart View 1 chunk +15 lines, -15 lines 0 comments Download
M lib/html/src/XMLDocumentWrappingImplementation.dart View 4 chunks +21 lines, -21 lines 0 comments Download
M lib/html/src/XMLElementWrappingImplementation.dart View 7 chunks +16 lines, -16 lines 0 comments Download
M lib/html/src/XMLHttpRequestProgressEvent.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/html/src/XMLHttpRequestProgressEventWrappingImplementation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/html/src/XMLHttpRequestUpload.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M lib/html/src/XMLHttpRequestUploadWrappingImplementation.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M lib/html/src/dart2js_DOMImplementation.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M lib/html/src/dart2js_LocationWrapper.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M lib/uri/uri.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/utf/utf16.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/utf/utf32.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/utf/utf_core.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/args/args.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/block_parser.dart View 12 chunks +20 lines, -20 lines 0 comments Download
M pkg/dartdoc/dartdoc.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/dartdoc/dropdown.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dartdoc/inline_parser.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/dartdoc/mirrors/dart2js_mirror.dart View 33 chunks +180 lines, -180 lines 0 comments Download
M pkg/dartdoc/mirrors/util.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/dartdoc/search.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/fixnum/int64.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M pkg/logging/logging.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/unittest/html_enhanced_config.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/byte_array.dart View 12 chunks +12 lines, -12 lines 0 comments Download
M runtime/lib/date_patch.dart View 4 chunks +11 lines, -11 lines 0 comments Download
M runtime/lib/immutable_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/isolate_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/mirrors_impl.dart View 32 chunks +46 lines, -46 lines 0 comments Download
M runtime/lib/regexp_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/weak_property.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/tests/vm/dart/isolate_mirror_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/calculator/calcui.dart View 4 chunks +84 lines, -84 lines 0 comments Download
M samples/calculator/settings.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M samples/calculator/tape.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M samples/chat/chat_server_lib.dart View 7 chunks +22 lines, -22 lines 0 comments Download
M samples/dartcombat/grids.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/dartcombat/setup.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/leap/leap_leg.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/leap/leap_script.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M samples/logo/logo.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/maps/js.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/maps/maps.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/markdown/ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/markdown/block_parser.dart View 12 chunks +20 lines, -20 lines 0 comments Download
M samples/markdown/inline_parser.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M samples/sample_extension/sample_asynchronous_extension.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/spirodraw/ColorPicker.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/App.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/BiIterator.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/DataSource.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M samples/swarm/SwarmState.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M samples/swarm/SwarmViews.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M samples/swarm/Views.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M samples/third_party/dromaeo/common/BenchUtil.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/dromaeo/common/Interval.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/third_party/todomvc/scripts/components.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/base/Device.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M samples/ui_lib/observable/observable.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M samples/ui_lib/touch/Geometry.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/touch/Momentum.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M samples/ui_lib/touch/Scrollbar.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/touch/Scroller.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M samples/ui_lib/touch/TouchUtil.dart View 4 chunks +38 lines, -38 lines 0 comments Download
M samples/ui_lib/view/MeasureText.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/view/view.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M samples/webcomponents/shadow_polyfill.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/benchmark_smoke/benchmark_base.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mirrors_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_mangling_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/bad_override_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/fauxverride_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/field1_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/field2_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/field6_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/field6a_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/local_function_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/override_field_method2_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/override_field_method5_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/pseudo_kw_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/toplevel_collision1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/toplevel_collision2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_advanced_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/io/http_basic_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/io/http_read_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/io/http_server_socket_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_working_directory_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_invalid_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/string_stream_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/utils/dummy.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/apidoc/mdn/extract.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M utils/apidoc/mdn/util.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/archive/entry.dart View 6 chunks +31 lines, -31 lines 0 comments Download
M utils/archive/input_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/archive/options.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/archive/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/css/source.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M utils/css/token.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/css/tokenizer.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/css/tokenkind.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/css/tree.dart View 16 chunks +29 lines, -29 lines 0 comments Download
M utils/css/world.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/peg/pegparser.dart View 11 chunks +12 lines, -12 lines 0 comments Download
M utils/template/codegen.dart View 12 chunks +23 lines, -23 lines 0 comments Download
M utils/template/htmltree.dart View 5 chunks +11 lines, -11 lines 0 comments Download
M utils/template/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/template/source.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M utils/template/token.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/template/tokenizer.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/template/tokenkind.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/template/world.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/string_encoding/benchmark_runner.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/tests/string_encoding/dunit.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M utils/tests/template/complex_datamodel.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/template/sample.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kasperl
8 years, 3 months ago (2012-09-07 10:52:20 UTC) #1
bakster
8 years, 3 months ago (2012-09-07 11:20:07 UTC) #2
STV,
  Lars

Powered by Google App Engine
This is Rietveld 408576698