Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: lib/coreimpl/queue.dart

Issue 10919146: Get rid of a lot of () for getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « lib/coreimpl/options.dart ('k') | lib/coreimpl/regexp.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 5
6 /** 6 /**
7 * An entry in a doubly linked list. It contains a pointer to the next 7 * An entry in a doubly linked list. It contains a pointer to the next
8 * entry, the previous entry, and the boxed element. 8 * entry, the previous entry, and the boxed element.
9 */ 9 */
10 class DoubleLinkedQueueEntry<E> { 10 class DoubleLinkedQueueEntry<E> {
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 } 45 }
46 46
47 DoubleLinkedQueueEntry<E> previousEntry() { 47 DoubleLinkedQueueEntry<E> previousEntry() {
48 return _previous._asNonSentinelEntry(); 48 return _previous._asNonSentinelEntry();
49 } 49 }
50 50
51 DoubleLinkedQueueEntry<E> nextEntry() { 51 DoubleLinkedQueueEntry<E> nextEntry() {
52 return _next._asNonSentinelEntry(); 52 return _next._asNonSentinelEntry();
53 } 53 }
54 54
55 E get element() { 55 E get element {
56 return _element; 56 return _element;
57 } 57 }
58 58
59 void set element(E e) { 59 void set element(E e) {
60 _element = e; 60 _element = e;
61 } 61 }
62 } 62 }
63 63
64 /** 64 /**
65 * A sentinel in a double linked list is used to manipulate the list 65 * A sentinel in a double linked list is used to manipulate the list
(...skipping 13 matching lines...) Expand all
79 79
80 DoubleLinkedQueueEntry<E> _asNonSentinelEntry() { 80 DoubleLinkedQueueEntry<E> _asNonSentinelEntry() {
81 return null; 81 return null;
82 } 82 }
83 83
84 void set element(E e) { 84 void set element(E e) {
85 // This setter is unreachable. 85 // This setter is unreachable.
86 assert(false); 86 assert(false);
87 } 87 }
88 88
89 E get element() { 89 E get element {
90 throw const EmptyQueueException(); 90 throw const EmptyQueueException();
91 } 91 }
92 } 92 }
93 93
94 /** 94 /**
95 * Implementation of a double linked list that box list elements into 95 * Implementation of a double linked list that box list elements into
96 * DoubleLinkedQueueEntry objects. 96 * DoubleLinkedQueueEntry objects.
97 */ 97 */
98 class DoubleLinkedQueue<E> implements Queue<E> { 98 class DoubleLinkedQueue<E> implements Queue<E> {
99 _DoubleLinkedQueueEntrySentinel<E> _sentinel; 99 _DoubleLinkedQueueEntrySentinel<E> _sentinel;
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 } 145 }
146 146
147 DoubleLinkedQueueEntry<E> lastEntry() { 147 DoubleLinkedQueueEntry<E> lastEntry() {
148 return _sentinel.previousEntry(); 148 return _sentinel.previousEntry();
149 } 149 }
150 150
151 DoubleLinkedQueueEntry<E> firstEntry() { 151 DoubleLinkedQueueEntry<E> firstEntry() {
152 return _sentinel.nextEntry(); 152 return _sentinel.nextEntry();
153 } 153 }
154 154
155 int get length() { 155 int get length {
156 int counter = 0; 156 int counter = 0;
157 forEach(void _(E element) { counter++; }); 157 forEach(void _(E element) { counter++; });
158 return counter; 158 return counter;
159 } 159 }
160 160
161 bool isEmpty() { 161 bool isEmpty() {
162 return (_sentinel._next === _sentinel); 162 return (_sentinel._next === _sentinel);
163 } 163 }
164 164
165 void clear() { 165 void clear() {
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 } 254 }
255 255
256 E next() { 256 E next() {
257 if (!hasNext()) { 257 if (!hasNext()) {
258 throw const NoMoreElementsException(); 258 throw const NoMoreElementsException();
259 } 259 }
260 _currentEntry = _currentEntry._next; 260 _currentEntry = _currentEntry._next;
261 return _currentEntry.element; 261 return _currentEntry.element;
262 } 262 }
263 } 263 }
OLDNEW
« no previous file with comments | « lib/coreimpl/options.dart ('k') | lib/coreimpl/regexp.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698