Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10919114: Expose functions to stringify IPv4 and IPv6 addresses (Closed)

Created:
8 years, 3 months ago by eroman
Modified:
7 years, 6 months ago
Reviewers:
thorogood, brettw
CC:
chromium-reviews
Base URL:
http://git.chromium.org/external/google-url.git@master
Visibility:
Public.

Description

Expose functions to stringify IPv4 and IPv6 addresses BUG=http://crbug.com/126212

Patch Set 1 #

Patch Set 2 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -34 lines) Patch
M src/url_canon_ip.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/url_canon_ip.cc View 1 6 chunks +30 lines, -34 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
Note that I did not add unittests, as this is already exercised by: URLCanonTest.IPv4 URLCanonTest.IPv6
8 years, 3 months ago (2012-09-06 03:05:16 UTC) #1
thorogood
On 2012/09/06 03:05:16, eroman wrote: > Note that I did not add unittests, as this ...
8 years, 3 months ago (2012-09-06 03:19:13 UTC) #2
eroman
I'll wait to hear back from brettw, since he usually reviews all the googleurl changes.
8 years, 3 months ago (2012-09-06 03:27:12 UTC) #3
brettw
8 years, 3 months ago (2012-09-06 20:38:08 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698