Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10919093: Rename GDataUplaoder to DriveUploader (Closed)

Created:
8 years, 3 months ago by kochi
Modified:
8 years, 3 months ago
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, satorux1, kinuko, nhiroki, Daniel Erat, mtomasz
Visibility:
Public.

Description

Rename GDataUplaoder to DriveUploader In this CL, * GDataUploader has been renamed to DriveUploader. * GDataUploaderInterface has been renamed to DriveUploaderInterface. * gdata_upload_file_info.{h,cc} have been renamed to drive_upload_file_info.{h,cc} * gdata_uploader.{h,cc} have been renamed to drive_uploader.{h,cc} * mock_gdata_uploader.{h,cc} have been renamed to mock_drive_uploader.{h,cc} * |gdata_path| in UploadFileInfo has been renamed to |drive_path| BUG=137151 TEST=pass all existing tests. TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155135

Patch Set 1 : . #

Patch Set 2 : rebase #

Patch Set 3 : fix after rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -975 lines) Patch
M chrome/browser/chromeos/gdata/drive_download_observer.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_download_observer.cc View 1 2 12 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system.h View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system_interface.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system_unittest.cc View 1 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_system_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_system_service.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/gdata/drive_upload_file_info.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/chromeos/gdata/drive_upload_file_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/gdata/drive_uploader.h View 6 chunks +13 lines, -13 lines 0 comments Download
A + chrome/browser/chromeos/gdata/drive_uploader.cc View 18 chunks +31 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operations.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/gdata/gdata_upload_file_info.h View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_upload_file_info.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_uploader.h View 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_uploader.cc View 1 chunk +0 lines, -483 lines 0 comments Download
A + chrome/browser/chromeos/gdata/mock_drive_uploader.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/chromeos/gdata/mock_drive_uploader.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/gdata/mock_gdata_uploader.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/chromeos/gdata/mock_gdata_uploader.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/gdata/stale_cache_files_remover_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kochi
Hi Kazuhiro, Could you review this? Thanks!
8 years, 3 months ago (2012-09-05 10:40:17 UTC) #1
kinaba
lgtm
8 years, 3 months ago (2012-09-06 02:13:54 UTC) #2
kochi
Thanks for the review! Added TBR=ben@chromium.org, for .gypi.
8 years, 3 months ago (2012-09-06 06:08:10 UTC) #3
Ben Goodger (Google)
8 years, 3 months ago (2012-09-06 21:21:45 UTC) #4
gyp lgtm

Powered by Google App Engine
This is Rietveld 408576698