Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 10919084: Disable several InstantTests that are failing on the linux_rel trybots, blocking the CQ (Closed)

Created:
8 years, 3 months ago by Ryan Sleevi
Modified:
8 years, 3 months ago
Reviewers:
Robert Sesek, sky
CC:
chromium-reviews, sreeram, gideonwald, dominich, David Black, Jered, Shishir
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Disable several InstantTests that are failing on the linux_rel trybots, blocking the CQ BUG=146419 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154839

Patch Set 1 #

Total comments: 1

Patch Set 2 : Ails to Fails #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -9 lines) Patch
M chrome/browser/instant/instant_browsertest.cc View 1 10 chunks +67 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
rsesek: PTAL for sheriff-y goodness sky: TBR jam felt strongly about disabling the tests (as ...
8 years, 3 months ago (2012-09-04 22:16:44 UTC) #1
Robert Sesek
8 years, 3 months ago (2012-09-04 22:19:00 UTC) #2
stampy LGTM

http://codereview.chromium.org/10919084/diff/1/chrome/browser/instant/instant...
File chrome/browser/instant/instant_browsertest.cc (right):

http://codereview.chromium.org/10919084/diff/1/chrome/browser/instant/instant...
chrome/browser/instant/instant_browsertest.cc:149: // Flakily ails in Release
builds - http://crbug.com/146419
*F*ails

Powered by Google App Engine
This is Rietveld 408576698