Disable several InstantTests that are failing on the linux_rel trybots, blocking the CQ

chrome/browser/instant/instant_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/stringprintf.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/instant/instant_controller.h"
@@ skipping 127 matching lines @@
   int onsubmitcalls_;
   int oncancelcalls_;
   int onresizecalls_;
 
   std::string value_;
   bool verbatim_;
   int height_;
 };
 
 // Test that Instant is preloaded when the omnibox is focused.
-IN_PROC_BROWSER_TEST_F(InstantTest, OmniboxFocusLoadsInstant) {
+#if defined(OS_LINUX) && defined(NDEBUG)
+// Flakily fails in Release builds - http://crbug.com/146419
+#define MAYBE_OmniboxFocusLoadsInstant DISABLED_OmniboxFocusLoadsInstant
+#else
+#define MAYBE_OmniboxFocusLoadsInstant OmniboxFocusLoadsInstant
+#endif
+IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE_OmniboxFocusLoadsInstant) {
   // The omnibox gets focus before the test begins. At this time, there's no
   // InstantController (which is only created in SetupInstant() below), so no
   // preloading has happened yet.
   ASSERT_NO_FATAL_FAILURE(SetupInstant("instant.html"));
   EXPECT_FALSE(instant()->GetPreviewContents());
 
   // Explicitly unfocus and refocus the omnibox. Since an InstantController now
   // exists, it will preload Instant.
   EXPECT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   ui_test_utils::ClickOnView(browser(), VIEW_ID_TAB_CONTAINER);
@@ skipping 25 matching lines @@
 
   EXPECT_EQ(preview_tab, instant()->GetPreviewContents());
 
   // Doing a search should also use the same preloaded page.
   SetOmniboxText("query");
   WaitFor(chrome::NOTIFICATION_INSTANT_CONTROLLER_SHOWN);
   EXPECT_TRUE(instant()->is_showing());
   EXPECT_EQ(preview_tab, instant()->GetPreviewContents());
 }
 
+#if defined(OS_LINUX) && defined(NDEBUG)
+// Flakily fails in Release builds - http://crbug.com/146419
+#define MAYBE_OnChangeEvent DISABLED_OnChangeEvent
+#else
+#define MAYBE_OnChangeEvent OnChangeEvent
+#endif
 // Test that the onchange event is dispatched upon typing in the omnibox.
-IN_PROC_BROWSER_TEST_F(InstantTest, OnChangeEvent) {
+IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE_OnChangeEvent) {
   ASSERT_NO_FATAL_FAILURE(SetupInstant("instant.html"));
 
   // Typing "query" into the omnibox causes the first onchange event.
   SetOmniboxText("query");
   WaitFor(chrome::NOTIFICATION_INSTANT_CONTROLLER_SHOWN);
 
   // The page suggested "query suggestion" is inline autocompleted into the
   // omnibox, causing the second onchange event.
   EXPECT_EQ(ASCIIToUTF16("query suggestion"), omnibox()->GetText());
   EXPECT_TRUE(UpdateSearchState(instant()->GetPreviewContents()));
   EXPECT_EQ(2, onchangecalls_);
 
   // Change the query and confirm that another onchange is sent. Since the new
   // query is not a prefix of the hardcoded "query suggestion", no inline
   // autocompletion happens, and thus, no fourth onchange event.
   SetOmniboxText("search");
   EXPECT_TRUE(UpdateSearchState(instant()->GetPreviewContents()));
   EXPECT_EQ(3, onchangecalls_);
 }
 
+#if defined(OS_LINUX) && defined(NDEBUG)
+// Flakily fails in Release builds - http://crbug.com/146419
+#define MAYBE_OnSubmitEvent DISABLED_OnSubmitEvent
+#else
+#define MAYBE_OnSubmitEvent OnSubmitEvent
+#endif
 // Test that the onsubmit event is dispatched upon pressing Enter.
-IN_PROC_BROWSER_TEST_F(InstantTest, OnSubmitEvent) {
+IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE_OnSubmitEvent) {
   ASSERT_NO_FATAL_FAILURE(SetupInstant("instant.html"));
   SetOmniboxText("search");
   WaitFor(chrome::NOTIFICATION_INSTANT_CONTROLLER_SHOWN);
 
   // Stash a reference to the preview, so we can refer to it after commit.
   TabContents* preview_tab = instant()->GetPreviewContents();
   EXPECT_TRUE(preview_tab);
 
   // The state of the searchbox before the commit.
   EXPECT_TRUE(UpdateSearchState(preview_tab));
@@ skipping 42 matching lines @@
   EXPECT_TRUE(UpdateSearchState(preview_tab));
   EXPECT_EQ("search", value_);
   EXPECT_TRUE(verbatim_);
   EXPECT_EQ(1, onsubmitcalls_);
 }
 
 // Test that the oncancel event is dispatched upon clicking on the preview.
 #if defined(OS_WIN)
 // Fails frequently on the win_rel tryserver.  crbug.com/145754
 #define MAYBE_OnCancelEvent DISABLED_OnCancelEvent
+#elif defined(OS_LINUX) && defined(NDEBUG)
+// Flakily fails in Release builds - http://crbug.com/146419
+#define MAYBE_OnCancelEvent DISABLED_OnCancelEvent
 #else
 #define MAYBE_OnCancelEvent OnCancelEvent
 #endif
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE_OnCancelEvent) {
   ASSERT_NO_FATAL_FAILURE(SetupInstant("instant.html"));
   SetOmniboxText("search");
   WaitFor(chrome::NOTIFICATION_INSTANT_CONTROLLER_SHOWN);
 
   // Stash a reference to the preview, so we can refer to it after commit.
   TabContents* preview_tab = instant()->GetPreviewContents();
@@ skipping 67 matching lines @@
   // Type a query into the omnibox. This should cause an onresize() event, with
   // a valid (non-zero) height.
   SetOmniboxText("search");
   WaitFor(chrome::NOTIFICATION_INSTANT_CONTROLLER_SHOWN);
 
   EXPECT_TRUE(UpdateSearchState(instant()->GetPreviewContents()));
   EXPECT_EQ(2, onresizecalls_);
   EXPECT_LT(0, height_);
 }
 
+#if defined(OS_LINUX) && defined(NDEBUG)
+// Flakily fails in Release builds - http://crbug.com/146419
+#define MAYBE_SuggestionIsCompletedNow DISABLED_SuggestionIsCompletedNow
+#else
+#define MAYBE_SuggestionIsCompletedNow SuggestionIsCompletedNow
+#endif
 // Test that the INSTANT_COMPLETE_NOW behavior works as expected.
-IN_PROC_BROWSER_TEST_F(InstantTest, SuggestionIsCompletedNow) {
+IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE_SuggestionIsCompletedNow) {
   ASSERT_NO_FATAL_FAILURE(SetupInstant("instant.html"));
   instant()->OnAutocompleteGotFocus();
   WaitFor(chrome::NOTIFICATION_INSTANT_SUPPORT_DETERMINED);
 
   // Tell the JS to request for the given behavior.
   EXPECT_TRUE(ExecuteScript("behavior = 'now'"));
 
   SetOmniboxText("query");
   WaitFor(chrome::NOTIFICATION_INSTANT_CONTROLLER_SHOWN);
 
@@ skipping 80 matching lines @@
 
   // Tell the JS to use the given suggestion.
   EXPECT_TRUE(ExecuteScript("suggestion = [ { value: 'query completion' } ]"));
 
   SetOmniboxText("query");
   WaitFor(chrome::NOTIFICATION_INSTANT_CONTROLLER_SHOWN);
 
   EXPECT_EQ(ASCIIToUTF16("query completion"), omnibox()->GetText());
 }
 
+#if defined(OS_LINUX) && defined(NDEBUG)
+// Flakily fails in Release builds - http://crbug.com/146419
+#define MAYBE_SuggestionIsInvalidObject DISABLED_SuggestionIsInvalidObject
+#else
+#define MAYBE_SuggestionIsInvalidObject SuggestionIsInvalidObject
+#endif
 // Test that an invalid suggestion is rejected.
-IN_PROC_BROWSER_TEST_F(InstantTest, SuggestionIsInvalidObject) {
+IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE_SuggestionIsInvalidObject) {
   ASSERT_NO_FATAL_FAILURE(SetupInstant("instant.html"));
   instant()->OnAutocompleteGotFocus();
   WaitFor(chrome::NOTIFICATION_INSTANT_SUPPORT_DETERMINED);
 
   // Tell the JS to use the given suggestion.
   EXPECT_TRUE(ExecuteScript("suggestion = { value: 'query completion' }"));
 
   SetOmniboxText("query");
   WaitFor(chrome::NOTIFICATION_INSTANT_CONTROLLER_SHOWN);
 
@@ skipping 108 matching lines @@
   // Type the same search as before. The preview should show, but no onchange()
   // is sent, since query hasn't changed.
   SetOmniboxText("search");
   EXPECT_TRUE(instant()->GetPreviewContents());
   EXPECT_TRUE(instant()->IsCurrent());
   EXPECT_TRUE(instant()->is_showing());
   EXPECT_TRUE(UpdateSearchState(instant()->GetPreviewContents()));
   EXPECT_EQ(2, onchangecalls_);
 }
 
+#if defined(OS_LINUX) && defined(NDEBUG)
+// Flakily fails in Release builds - http://crbug.com/146419
+#define MAYBE_DoesNotCommitURLs DISABLED_DoesNotCommitURLs
+#else
+#define MAYBE_DoesNotCommitURLs DoesNotCommitURLs
+#endif
 // Test that Instant can't be fooled into committing a URL.
-IN_PROC_BROWSER_TEST_F(InstantTest, DoesNotCommitURLs) {
+IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE_DoesNotCommitURLs) {
   ASSERT_NO_FATAL_FAILURE(SetupInstant("instant.html"));
   EXPECT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
 
   // Type a URL. No Instant.
   SetOmniboxText("http://deadly/nadder");
   EXPECT_FALSE(instant()->GetPreviewContents());
 
   // Unfocus and refocus the omnibox.
   ui_test_utils::ClickOnView(browser(), VIEW_ID_TAB_CONTAINER);
   EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_TAB_CONTAINER));
@@ skipping 38 matching lines @@
   EXPECT_EQ(active_tab, chrome::GetActiveTabContents(browser()));
   EXPECT_NE(preview_tab, active_tab);
   EXPECT_EQ(ASCIIToUTF16("hideous/zippleback"), omnibox()->GetText());
 
   // As before, Instant shouldn't have done anything.
   EXPECT_EQ(preview_tab, instant()->GetPreviewContents());
   EXPECT_FALSE(instant()->IsCurrent());
   EXPECT_FALSE(instant()->is_showing());
 }
 
+#if defined(OS_LINUX) && defined(NDEBUG)
+// Flakily fails in Release builds - http://crbug.com/146419
+#define MAYBE_NonInstantSearchProvider DISABLED_NonInstantSearchProvider
+#else
+#define MAYBE_NonInstantSearchProvider NonInstantSearchProvider
+#endif
 // Test that a non-Instant search provider shows no previews.
-IN_PROC_BROWSER_TEST_F(InstantTest, NonInstantSearchProvider) {
+IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE_NonInstantSearchProvider) {
   ASSERT_NO_FATAL_FAILURE(SetupInstant("empty.html"));
 
   // Type a query. Instant will load the search provider.
   SetOmniboxText("query");
   EXPECT_TRUE(instant()->GetPreviewContents());
 
   // When the response comes back, Instant will destroy the non-Instant page.
   WaitFor(chrome::NOTIFICATION_INSTANT_SUPPORT_DETERMINED);
   EXPECT_FALSE(instant()->GetPreviewContents());
 }
@@ skipping 77 matching lines @@
 
 void KeywordQueryDone(base::RunLoop* run_loop,
                       std::vector<string16>* result,
                       HistoryService::Handle  /* handle */,
                       std::vector<history::KeywordSearchTermVisit>* terms) {
   for (size_t i = 0; i < terms->size(); ++i)
     result->push_back((*terms)[i].term);
   run_loop->Quit();
 }
 
+#if defined(OS_LINUX) && defined(NDEBUG)
+// Flakily fails in Release builds - http://crbug.com/146419
+#define MAYBE_History DISABLED_History
+#else
+#define MAYBE_History History
+#endif
 // Test that the Instant page load is not added to history.
-IN_PROC_BROWSER_TEST_F(InstantTest, History) {
+IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE_History) {
   ASSERT_NO_FATAL_FAILURE(SetupInstant("instant.html"));
   instant()->OnAutocompleteGotFocus();
   WaitFor(chrome::NOTIFICATION_INSTANT_SUPPORT_DETERMINED);
 
   const TemplateURL* template_url = TemplateURLServiceFactory::GetForProfile(
       browser()->profile())->GetDefaultSearchProvider();
 
   // |instant_url| is the URL Instant loads. |search_url| is the fake URL we
   // enter into history for search terms extraction to work correctly.
   std::string search_url = template_url->url_ref().ReplaceSearchTerms(
@@ skipping 39 matching lines @@
   run_loop3.Run();
   ASSERT_TRUE(queries.size());
   EXPECT_EQ(ASCIIToUTF16("search"), queries[0]);
 }
 
 // On Windows, the call to NewEmptyWindow() fails the "GetBackingStore called
 // while hidden" DCHECK(). It's not clear why; maybe because the active tab is
 // in a hidden state when the Instant preview is showing, and somebody's trying
 // to get its backing store?
 #if !defined(OS_WIN)
+
+#if defined(OS_LINUX) && defined(NDEBUG)
+// Flakily fails in Release builds - http://crbug.com/146419
+#define MAYBE_NewWindowDismissesInstant DISABLED_NewWindowDismissesInstant
+#else
+#define MAYBE_NewWindowDismissesInstant NewWindowDismissesInstant
+#endif
 // Test that creating a new window hides any currently showing Instant preview.
-IN_PROC_BROWSER_TEST_F(InstantTest, NewWindowDismissesInstant) {
+IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE_NewWindowDismissesInstant) {
   ASSERT_NO_FATAL_FAILURE(SetupInstant("instant.html"));
   instant()->OnAutocompleteGotFocus();
   WaitFor(chrome::NOTIFICATION_INSTANT_SUPPORT_DETERMINED);
 
   EXPECT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   SetOmniboxText("search");
   WaitFor(chrome::NOTIFICATION_INSTANT_CONTROLLER_SHOWN);
   EXPECT_TRUE(instant()->GetPreviewContents());
   EXPECT_TRUE(instant()->IsCurrent());
   EXPECT_TRUE(instant()->is_showing());
@@ skipping 32 matching lines @@
   // Refresh the loader, the preview contents should remain the same.
   instant()->OnStaleLoader();
   EXPECT_TRUE(instant()->is_showing());
 
   instant()->stale_loader_timer_.Stop();
   // The refresh should happen once the omnibox loses focus.
   EXPECT_TRUE(instant()->loader()->supports_instant());
   instant()->OnAutocompleteLostFocus(NULL);
   EXPECT_FALSE(instant()->loader()->supports_instant());
 }