Show the stack trace for renderer process crashes.

Show the stack trace for renderer process crashes.

Having a stack trace is helpful for developers, especially on Linux
where gdb can be slow to start and require complex command line flags
for the renderer process.

Only enabled on debug builds without the sandbox.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156856

[tony, 2012-09-12 18:13:57]

The comment in the header says that this is meant to be used in unit_tests only.
 Is it OK for me to enable on debug builds?

We already set this in test_shell, test_shell_tests and DumpRenderTree.

[M-A Ruel, 2012-09-12 18:25:03]

I'm personally fine with this, let's have Paweł confirm if he has time.

lgtm

[Paweł Hajdan Jr., 2012-09-13 07:19:22]

The code change looks fine, but could you please explain more:

1) Why is this needed? Mostly for future reference in case things need to be
changed or applied in more places.

2) Why is this enabled only when sandbox is disabled? Are there any interactions
with the sandbox? Please add a comment about that in the code.

[tony, 2012-09-13 17:03:20]

On 2012/09/13 07:19:22, Paweł Hajdan Jr. wrote:
> The code change looks fine, but could you please explain more:
> 
> 1) Why is this needed? Mostly for future reference in case things need to be
> changed or applied in more places.

I updated the change description to say this is just to aid in debugging.

> 2) Why is this enabled only when sandbox is disabled? Are there any
interactions
> with the sandbox? Please add a comment about that in the code.

We can't get symbols when the sandbox is enabled.  I added a comment about this
to the code.

[tony, 2012-09-13 17:04:11]

+jamesr for OWNERS.

[jamesr, 2012-09-13 17:08:11]

lgtm

[Paweł Hajdan Jr., 2012-09-14 06:50:20]

LGTM

[commit-bot: I haz the power, 2012-09-14 17:19:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/10918198/7001

[commit-bot: I haz the power, 2012-09-14 17:45:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/10918198/7001

[commit-bot: I haz the power, 2012-09-14 19:11:36]

Change committed as 156856