Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: content/renderer/renderer_main.cc

Issue 10918198: Show the stack trace for renderer process crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/renderer_main.cc
diff --git a/content/renderer/renderer_main.cc b/content/renderer/renderer_main.cc
index e827686abd877ef9d86c3517eaaba667f62192f2..f6dc886c184605915003b664676ac5fec5523f4f 100644
--- a/content/renderer/renderer_main.cc
+++ b/content/renderer/renderer_main.cc
@@ -212,6 +212,12 @@ int RendererMain(const content::MainFunctionParams& parameters) {
run_loop = platform.EnableSandbox();
} else {
LOG(ERROR) << "Running without renderer sandbox";
+#ifndef NDEBUG
+ // For convenience, we print the stack trace for crashes. We can't get
+ // symbols when the sandbox is enabled, so only try when the sandbox is
+ // disabled.
+ base::EnableInProcessStackDumping();
+#endif
}
#if defined(OS_POSIX) && !defined(OS_MACOSX)
RenderProcessImpl render_process;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698