Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.cc

Issue 10918182: Don't require a recreation of the context when fullscreening (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix style Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/ppapi_plugin_instance.cc
diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.cc b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
index 600fc44f87dc78d3f9e5d2b59cf094c628aa2d2f..464c7beec77bc544bc8e392a52d38632ffdcedd9 100644
--- a/webkit/plugins/ppapi/ppapi_plugin_instance.cc
+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
@@ -1604,6 +1604,7 @@ bool PluginInstance::SetFullscreen(bool fullscreen) {
}
void PluginInstance::FlashSetFullscreen(bool fullscreen, bool delay_report) {
+ TRACE_EVENT0("ppapi", "PluginInstance::FlashSetFullscreen");
// Keep a reference on the stack. See NOTE above.
scoped_refptr<PluginInstance> ref(this);
@@ -1614,10 +1615,10 @@ void PluginInstance::FlashSetFullscreen(bool fullscreen, bool delay_report) {
return;
// Unbind current 2D or 3D graphics context.
- BindGraphics(pp_instance(), 0);
VLOG(1) << "Setting fullscreen to " << (fullscreen ? "on" : "off");
if (fullscreen) {
DCHECK(!fullscreen_container_);
+ setBackingTextureId(0, false);
fullscreen_container_ = delegate_->CreateFullscreenContainer(this);
} else {
DCHECK(fullscreen_container_);
@@ -1643,6 +1644,17 @@ void PluginInstance::UpdateFlashFullscreenState(bool flash_fullscreen) {
return;
}
+ PPB_Graphics3D_Impl* graphics_3d = GetBoundGraphics3D();
+ if (graphics_3d) {
+ if (flash_fullscreen) {
+ fullscreen_container_->ReparentContext(graphics_3d->platform_context());
+ } else {
+ delegate_->ReparentContext(graphics_3d->platform_context());
+ setBackingTextureId(graphics_3d->GetBackingTextureId(),
+ graphics_3d->IsOpaque());
+ }
+ }
+
bool old_plugin_focus = PluginHasFocus();
flash_fullscreen_ = flash_fullscreen;
if (is_mouselock_pending && !delegate()->IsMouseLocked(this)) {
@@ -2003,6 +2015,7 @@ void PluginInstance::ClosePendingUserGesture(PP_Instance instance,
PP_Bool PluginInstance::BindGraphics(PP_Instance instance,
PP_Resource device) {
+ TRACE_EVENT0("ppapi", "PluginInstance::BindGraphics");
// The Graphics3D instance can't be destroyed until we call
// setBackingTextureId.
scoped_refptr< ::ppapi::Resource> old_graphics = bound_graphics_;
« ppapi/cpp/private/flash_fullscreen.cc ('K') | « webkit/plugins/ppapi/plugin_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698