Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: ppapi/cpp/private/flash_fullscreen.cc

Issue 10918182: Don't require a recreation of the context when fullscreening (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix style Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/cpp/private/flash_fullscreen.h ('k') | ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/private/flash_fullscreen.cc
diff --git a/ppapi/cpp/private/flash_fullscreen.cc b/ppapi/cpp/private/flash_fullscreen.cc
index 8a5be263f64c754a588a6406e439cd7d7c6f08bc..dd17b1a15d452cf174ed769cee4a463607c1d347 100644
--- a/ppapi/cpp/private/flash_fullscreen.cc
+++ b/ppapi/cpp/private/flash_fullscreen.cc
@@ -14,8 +14,12 @@ namespace pp {
namespace {
-template <> const char* interface_name<PPB_FlashFullscreen>() {
- return PPB_FLASHFULLSCREEN_INTERFACE;
+template <> const char* interface_name<PPB_FlashFullscreen_0_1>() {
+ return PPB_FLASHFULLSCREEN_INTERFACE_0_1;
+}
+
+template <> const char* interface_name<PPB_FlashFullscreen_1_0>() {
+ return PPB_FLASHFULLSCREEN_INTERFACE_1_0;
}
} // namespace
@@ -28,23 +32,27 @@ FlashFullscreen::~FlashFullscreen() {
}
bool FlashFullscreen::IsFullscreen() {
- return has_interface<PPB_FlashFullscreen>() &&
- get_interface<PPB_FlashFullscreen>()->IsFullscreen(
+ return has_interface<PPB_FlashFullscreen_0_1>() &&
viettrungluu 2012/09/20 21:13:51 You should really do: if (has_interface<PPB_Flash
+ get_interface<PPB_FlashFullscreen_0_1>()->IsFullscreen(
instance_.pp_instance());
}
bool FlashFullscreen::SetFullscreen(bool fullscreen) {
- if (!has_interface<PPB_FlashFullscreen>())
+ if (!has_interface<PPB_FlashFullscreen_0_1>())
viettrungluu 2012/09/20 21:13:51 "
return false;
- return PP_ToBool(get_interface<PPB_FlashFullscreen>()->SetFullscreen(
+ return PP_ToBool(get_interface<PPB_FlashFullscreen_0_1>()->SetFullscreen(
instance_.pp_instance(), PP_FromBool(fullscreen)));
}
bool FlashFullscreen::GetScreenSize(Size* size) {
- if (!has_interface<PPB_FlashFullscreen>())
+ if (!has_interface<PPB_FlashFullscreen_0_1>())
viettrungluu 2012/09/20 21:13:51 "
return false;
- return PP_ToBool(get_interface<PPB_FlashFullscreen>()->GetScreenSize(
+ return PP_ToBool(get_interface<PPB_FlashFullscreen_0_1>()->GetScreenSize(
instance_.pp_instance(), &size->pp_size()));
}
+bool FlashFullscreen::MustRecreateContexts() {
+ return !get_interface<PPB_FlashFullscreen_1_0>();
+}
+
} // namespace pp
« no previous file with comments | « ppapi/cpp/private/flash_fullscreen.h ('k') | ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698