Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2375)

Unified Diff: ppapi/api/private/ppb_flash_fullscreen.idl

Issue 10918182: Don't require a recreation of the context when fullscreening (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix style Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/api/private/ppb_flash_fullscreen.idl
diff --git a/ppapi/api/private/ppb_flash_fullscreen.idl b/ppapi/api/private/ppb_flash_fullscreen.idl
index b646e8f09eba934492999c0f0baad403bada24a1..11f94e4d402aa609e678120d75b87062e18ec6ee 100644
--- a/ppapi/api/private/ppb_flash_fullscreen.idl
+++ b/ppapi/api/private/ppb_flash_fullscreen.idl
@@ -9,7 +9,8 @@
*/
label Chrome {
- M16 = 0.1
+ M16 = 0.1,
+ M23 = 1.0
};
interface PPB_FlashFullscreen {
@@ -19,21 +20,27 @@ interface PPB_FlashFullscreen {
PP_Bool IsFullscreen(
[in] PP_Instance instance);
+ /*
+ * This older version required that graphics contexts be recreated after the
+ * transition.
+ */
+ [version=0.1, deprecate=1.0]
+ PP_Bool SetFullscreen(
+ [in] PP_Instance instance,
+ [in] PP_Bool fullscreen);
+
/**
* Switches the plugin instance to/from fullscreen mode. Returns PP_TRUE on
* success, PP_FALSE on failure.
*
- * This unbinds the current Graphics2D or Graphics3D. Pending flushes and
- * swapbuffers will execute as if the resource was off-screen. The transition
- * is asynchronous. During the transition, IsFullscreen will return PP_FALSE,
- * and no Graphics2D or Graphics3D can be bound. The transition ends at the
- * next DidChangeView when going into fullscreen mode. The transition out of
- * fullscreen mode is synchronous.
- *
- * Note: when switching to and from fullscreen, Graphics3D resources need to
- * be re-created. This is a current limitation that will be lifted in a later
- * revision.
+ * This does not unbind the current Graphics2D or Graphics3D. Pending flushes
+ * and swapbuffers will execute as if the resource was off-screen. The
+ * transition is asynchronous. During the transition, IsFullscreen will
+ * return PP_FALSE, and no Graphics2D or Graphics3D can be bound. The
+ * transition ends at the next DidChangeView when going into fullscreen mode.
+ * The transition out of fullscreen mode is synchronous.
*/
+ [version=1.0]
PP_Bool SetFullscreen(
[in] PP_Instance instance,
[in] PP_Bool fullscreen);

Powered by Google App Engine
This is Rietveld 408576698