chrome/browser/ui/webui/ntp/app_launcher_handler.cc - Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.cc

Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove the auxiliary structure for non-URL cases. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc ('k') | chrome/browser/ui/webui/ntp/favicon_webui_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/app_launcher_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc

index 1cbc800b11a78c2744fc0cff013b8a077eb06326..75cda30d61b3e66ff88c4b35cc7d9e6ffeb722c4 100644

--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc

+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc

@@ -706,8 +706,8 @@ void AppLauncherHandler::HandleGenerateAppForLink(const ListValue* args) {

install_info->page_ordinal = page_ordinal;

FaviconService::Handle h = favicon_service->GetFaviconImageForURL(

- profile, launch_url, history::FAVICON, gfx::kFaviconSize,

- &favicon_consumer_,

+ FaviconService::FaviconForURLParams(profile, launch_url, history::FAVICON,

James Hawkins 2012/09/05 22:39:50 nit: The start of param rows must align on the sam

+ gfx::kFaviconSize, &favicon_consumer_),

base::Bind(&AppLauncherHandler::OnFaviconForApp, base::Unretained(this)));

favicon_consumer_.SetClientData(favicon_service, h, install_info.release());

}

« no previous file with comments | « chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc ('k') | chrome/browser/ui/webui/ntp/favicon_webui_handler.cc » ('j') | no next file with comments »