Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2748)

Unified Diff: chrome/browser/ui/webui/ntp/favicon_webui_handler.cc

Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove the auxiliary structure for non-URL cases. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/favicon_webui_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc b/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc
index 90b27a667887bae8421e596d50af56c5beefc221..5e4481522fe18d5e01995222be59317c9fa5450a 100644
--- a/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc
+++ b/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc
@@ -111,12 +111,13 @@ void FaviconWebUIHandler::HandleGetFaviconDominantColor(const ListValue* args) {
dom_id_map_[id_] = dom_id;
FaviconService::Handle handle = favicon_service->GetRawFaviconForURL(
- Profile::FromWebUI(web_ui()),
- url,
- history::FAVICON,
- gfx::kFaviconSize,
+ FaviconService::FaviconForURLParams(
+ Profile::FromWebUI(web_ui()),
+ url,
+ history::FAVICON,
+ gfx::kFaviconSize,
+ &consumer_),
ui::SCALE_FACTOR_100P,
- &consumer_,
base::Bind(&FaviconWebUIHandler::OnFaviconDataAvailable,
base::Unretained(this)));
consumer_.SetClientData(favicon_service, handle, id_++);

Powered by Google App Engine
This is Rietveld 408576698