Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10918027: Revert 154457 - Switch from SignedSettings to DeviceSettingsService. (Closed)

Created:
8 years, 3 months ago by dmazzoni
Modified:
8 years, 3 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 154457 - Switch from SignedSettings to DeviceSettingsService. This broke GoogleUpdateTest.StatsConsent on Linux ChromiumOS bots. Check the try jobs from the original code review - the same test failed on the Linux ChromeOS Valgrind bot. DevicePolicyCache and DeviceSettingsProvider now go through DeviceSettingsService, which provides a unified and simpler API to Chrome OS device settings. BUG=chromium:139126 TEST=Unit tests, everything related to enterprise enrollment and device settings still works. TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832035 TBR=mnissler@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1118 lines, -987 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 4 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_idle_logout_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/locale_change_guard.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 4 chunks +4 lines, -12 lines 0 comments Download
MM chrome/browser/chromeos/login/existing_user_controller.cc View 6 chunks +29 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/login/language_switch_menu.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_performer.h View 3 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/login_performer.cc View 3 chunks +48 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.h View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.cc View 7 chunks +26 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.h View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 9 chunks +47 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings.h View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings.cc View 7 chunks +89 lines, -84 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_provider.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_unittest.cc View 12 chunks +58 lines, -23 lines 0 comments Download
D chrome/browser/chromeos/settings/device_settings_cache.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/chromeos/settings/device_settings_cache.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/chromeos/settings/device_settings_cache_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.h View 5 chunks +60 lines, -53 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 15 chunks +221 lines, -194 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 6 chunks +124 lines, -116 lines 0 comments Download
M chrome/browser/chromeos/settings/owner_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_cache.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_cache.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_cache_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_migration_helper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_migration_helper.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/chromeos/settings/stub_cros_settings_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/stub_cros_settings_provider.cc View 1 chunk +3 lines, -0 lines 0 comments Download
MM chrome/browser/chromeos/settings/system_settings_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
MM chrome/browser/chromeos/settings/system_settings_provider.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/policy/device_policy_cache.h View 5 chunks +22 lines, -14 lines 0 comments Download
M chrome/browser/policy/device_policy_cache.cc View 11 chunks +116 lines, -52 lines 0 comments Download
M chrome/browser/policy/device_policy_cache_unittest.cc View 3 chunks +187 lines, -120 lines 0 comments Download
MM chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dmazzoni
8 years, 3 months ago (2012-08-31 19:45:37 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698