Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 10918007: Delay predictor DB access until after the first main frame load complete. (Closed)

Created:
8 years, 3 months ago by dominich
Modified:
8 years, 3 months ago
Reviewers:
Shishir
CC:
chromium-reviews, jeremy, tonyg
Visibility:
Public.

Description

Delay predictor DB access until after the first main frame load complete. There might be better notifications to use, but at least allowing the main frame to complete one load should speed up initial boot. BUG=136602 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154301

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M chrome/browser/predictors/autocomplete_action_predictor.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor.cc View 3 chunks +26 lines, -10 lines 2 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dominich
8 years, 3 months ago (2012-08-30 18:37:41 UTC) #1
Shishir
https://chromiumcodereview.appspot.com/10918007/diff/1/chrome/browser/predictors/autocomplete_action_predictor.cc File chrome/browser/predictors/autocomplete_action_predictor.cc (right): https://chromiumcodereview.appspot.com/10918007/diff/1/chrome/browser/predictors/autocomplete_action_predictor.cc#newcode97 chrome/browser/predictors/autocomplete_action_predictor.cc:97: HistoryService* history_service = HistoryServiceFactory::GetForProfile( Does it make sense to ...
8 years, 3 months ago (2012-08-30 18:51:08 UTC) #2
dominich
https://chromiumcodereview.appspot.com/10918007/diff/1/chrome/browser/predictors/autocomplete_action_predictor.cc File chrome/browser/predictors/autocomplete_action_predictor.cc (right): https://chromiumcodereview.appspot.com/10918007/diff/1/chrome/browser/predictors/autocomplete_action_predictor.cc#newcode97 chrome/browser/predictors/autocomplete_action_predictor.cc:97: HistoryService* history_service = HistoryServiceFactory::GetForProfile( On 2012/08/30 18:51:08, Shishir wrote: ...
8 years, 3 months ago (2012-08-30 18:53:57 UTC) #3
Shishir
lgtm
8 years, 3 months ago (2012-08-30 18:55:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominich@chromium.org/10918007/1
8 years, 3 months ago (2012-08-30 19:49:56 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-08-30 23:10:17 UTC) #6
Change committed as 154301

Powered by Google App Engine
This is Rietveld 408576698