Switch NOTIFICATION_TAB_PARENTED to use WebContents.

Switch NOTIFICATION_TAB_PARENTED to use WebContents.

BUG=107201
TEST=no visible change


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157134

[Avi (use Gerrit), 2012-09-11 21:26:00]

Jim:

I'm sending this to you because of the metrics change. I'm less concerned about
how it got to be this way, but this change fixes what appears to me to be
completely broken. With this change, I made sure that we're removing entries
from the map that match the ones we're putting in, making sure that they're all
of the type documented (NavController).

PTAL; ask me any questions you may have.

[Avi (use Gerrit), 2012-09-13 18:29:10]

Jim isn't responding; Ilya, can you take a look? I switched out the notification
source and found that the metric code was completely broken as it exists. I
cleaned it up just enough so that it makes sense.

[jar (doing other things), 2012-09-14 01:46:45]

Yes... sorry... I'm overloaded. If Ilya can help, that would be appreciated.

Jim

On Thu, Sep 13, 2012 at 11:29 AM, <avi@chromium.org> wrote:

> Jim isn't responding; Ilya, can you take a look? I switched out the
> notification
> source and found that the metric code was completely broken as it exists. I
> cleaned it up just enough so that it makes sense.
>
>
https://chromiumcodereview.**appspot.com/10917198/<https://chromiumcodereview...
>

[Avi (use Gerrit), 2012-09-14 20:37:12]

I'll take any reviewer, please.

[Ilya Sherman, 2012-09-14 21:34:17]

metrics/ changes LGTM.

This is code that will be pruned away RSN anyway... nobody looks at this part of
the UMA upload, and it's not part of the (newer) protobuf-based upload system.

[Avi (use Gerrit), 2012-09-14 22:03:24]

Scott, can you take an overall look?

[sky, 2012-09-14 23:30:51]

LGTM

[commit-bot: I haz the power, 2012-09-15 00:39:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10917198/9009

[commit-bot: I haz the power, 2012-09-15 01:47:46]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-15 15:00:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10917198/9009

[commit-bot: I haz the power, 2012-09-15 15:30:51]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-17 15:00:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10917198/9012

[commit-bot: I haz the power, 2012-09-17 15:00:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10917198/9012

[commit-bot: I haz the power, 2012-09-17 17:08:14]

Change committed as 157134