Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 10917198: Switch NOTIFICATION_TAB_PARENTED to use WebContents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tab_id_map.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.h
diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h
index ff2d5ebff05470b8d283a1be2240a7f6aaa5029f..77dc4d5922604aed24b62bbc33def29054522c09 100644
--- a/chrome/browser/metrics/metrics_service.h
+++ b/chrome/browser/metrics/metrics_service.h
@@ -328,10 +328,9 @@ class MetricsService
// code other than 200.
void LogBadResponseCode(int response_code, bool is_xml);
- // Records a window-related notification.
- void LogWindowChange(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details);
+ // Records a window-related notification. |window_or_tab| is either a pointer
+ // to a WebContents (for a tab) or a Browser (for a window).
+ void LogWindowOrTabChange(int type, uintptr_t window_or_tab);
// Reads, increments and then sets the specified integer preference.
void IncrementPrefValue(const char* path);
@@ -453,9 +452,9 @@ class MetricsService
// A number that identifies the how many times the app has been launched.
int session_id_;
- // Maps NavigationControllers (corresponding to tabs) or Browser
- // (corresponding to Windows) to a unique integer that we will use to identify
- // it. |next_window_id_| is used to track which IDs we have used so far.
+ // Maps WebContentses (corresponding to tabs) or Browsers (corresponding to
+ // Windows) to a unique integer that we will use to identify them.
+ // |next_window_id_| is used to track which IDs we have used so far.
typedef std::map<uintptr_t, int> WindowMap;
WindowMap window_map_;
int next_window_id_;
« no previous file with comments | « chrome/browser/extensions/extension_tab_id_map.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698