content/browser/renderer_host/p2p/socket_host.h - Issue 10917167: Refactor the P2PSocketDispatcher to be created on the RenderThread instead of the RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host.h

Issue 10917167: Refactor the P2PSocketDispatcher to be created on the RenderThread instead of the RenderView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change P2PSocketDispatcher to take the io message loop as input to fix existing unit tests Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/p2p/socket_dispatcher_host.cc ('K') | « content/browser/renderer_host/p2p/socket_dispatcher_host.cc ('k') | content/browser/renderer_host/p2p/socket_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/p2p/socket_host.h

diff --git a/content/browser/renderer_host/p2p/socket_host.h b/content/browser/renderer_host/p2p/socket_host.h

index a7dcade31902a022491e66ffbf0abe527a27cc0c..25a827fd416c10d6320dd23bf4ae78314cf7994b 100644

--- a/content/browser/renderer_host/p2p/socket_host.h

+++ b/content/browser/renderer_host/p2p/socket_host.h

@@ -18,7 +18,7 @@ class CONTENT_EXPORT P2PSocketHost {

public:

// Creates P2PSocketHost of the specific type.

static P2PSocketHost* Create(IPC::Sender* message_sender,

- int routing_id, int id, P2PSocketType type);

+ int id, P2PSocketType type);

virtual ~P2PSocketHost();

@@ -68,7 +68,7 @@ class CONTENT_EXPORT P2PSocketHost {

// see crbug.com/91495 .

static const int kMaxSendBufferSize = 256 * 1024;

- P2PSocketHost(IPC::Sender* message_sender, int routing_id, int id);

+ P2PSocketHost(IPC::Sender* message_sender, int id);

// Verifies that the packet |data| has a valid STUN header. In case

// of success stores type of the message in |type|.

@@ -77,7 +77,6 @@ class CONTENT_EXPORT P2PSocketHost {

static bool IsRequestOrResponse(StunMessageType type);

IPC::Sender* message_sender_;

- int routing_id_;

int id_;

State state_;