Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: content/browser/renderer_host/p2p/socket_host.cc

Issue 10917167: Refactor the P2PSocketDispatcher to be created on the RenderThread instead of the RenderView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change P2PSocketDispatcher to take the io message loop as input to fix existing unit tests Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/p2p/socket_host.cc
diff --git a/content/browser/renderer_host/p2p/socket_host.cc b/content/browser/renderer_host/p2p/socket_host.cc
index f17ae9e46de14dc3618d4072f1804c288c54dbc9..40d173a9518c28dee43987f6deaa47c79a11ee0d 100644
--- a/content/browser/renderer_host/p2p/socket_host.cc
+++ b/content/browser/renderer_host/p2p/socket_host.cc
@@ -16,10 +16,8 @@ const uint32 kStunMagicCookie = 0x2112A442;
namespace content {
-P2PSocketHost::P2PSocketHost(IPC::Sender* message_sender,
- int routing_id, int id)
+P2PSocketHost::P2PSocketHost(IPC::Sender* message_sender, int id)
: message_sender_(message_sender),
- routing_id_(routing_id),
id_(id),
state_(STATE_UNINITIALIZED) {
}
@@ -75,17 +73,16 @@ bool P2PSocketHost::IsRequestOrResponse(StunMessageType type) {
// static
P2PSocketHost* P2PSocketHost::Create(
- IPC::Sender* message_sender, int routing_id, int id,
- P2PSocketType type) {
+ IPC::Sender* message_sender, int id, P2PSocketType type) {
switch (type) {
case P2P_SOCKET_UDP:
- return new P2PSocketHostUdp(message_sender, routing_id, id);
+ return new P2PSocketHostUdp(message_sender, id);
case P2P_SOCKET_TCP_SERVER:
- return new P2PSocketHostTcpServer(message_sender, routing_id, id);
+ return new P2PSocketHostTcpServer(message_sender, id);
case P2P_SOCKET_TCP_CLIENT:
- return new P2PSocketHostTcp(message_sender, routing_id, id);
+ return new P2PSocketHostTcp(message_sender, id);
}
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698