content/browser/web_contents/web_contents_impl.cc - Issue 10917102: Context menus should appear above the touch point if invoked by long press.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 10917102: Context menus should appear above the touch point if invoked by long press. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.cc ('K') | « content/browser/web_contents/web_contents_impl.h ('k') | content/browser/web_contents/web_contents_view_android.h » ('j') | content/public/common/context_menu_event_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index c8e64f16b1c2294a75409046f288ba16b05ae083..340f9692864eceb1fe63b0e8bb0c7a2977a53d15 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -1418,12 +1418,13 @@ RenderWidgetHostView* WebContentsImpl::GetCreatedWidget(int route_id) {

}

void WebContentsImpl::ShowContextMenu(

- const content::ContextMenuParams& params) {

+ const content::ContextMenuParams& params,

+ const content::ContextMenuEventType& type) {

// Allow WebContentsDelegates to handle the context menu operation first.

if (delegate_ && delegate_->HandleContextMenu(params))

return;

- render_view_host_delegate_view_->ShowContextMenu(params);

+ render_view_host_delegate_view_->ShowContextMenu(params, type);

}

void WebContentsImpl::RequestMediaAccessPermission(