content/browser/renderer_host/render_view_host_impl.cc - Issue 10917102: Context menus should appear above the touch point if invoked by long press.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 10917102: Context menus should appear above the touch point if invoked by long press. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_delegate.h ('k') | content/browser/renderer_host/render_view_host_unittest.cc » ('j') | content/public/common/context_menu_event_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 8ad9eed96fd9ff9ef88adc439dd0f1abf79621b1..ea9d490779c65690d88be49da3e7fb21a1e2efb1 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -53,6 +53,7 @@

#include "content/public/common/content_constants.h"

#include "content/public/common/content_switches.h"

#include "content/public/common/context_menu_params.h"

+#include "content/public/common/context_menu_event_type.h"

#include "content/public/common/result_codes.h"

#include "content/public/common/url_constants.h"

#include "net/base/net_util.h"

@@ -1241,7 +1242,16 @@ void RenderViewHostImpl::OnMsgContextMenu(

FilterURL(policy, renderer_id, false, &validated_params.page_url);

FilterURL(policy, renderer_id, true, &validated_params.frame_url);

- delegate_->ShowContextMenu(validated_params);

+ content::ContextMenuEventType type = content::NO_CONTEXT_MENU;

sky 2012/09/05 23:57:00 When can we hit this?

varunjain 2012/09/06 03:49:55 I included this to represent the case where javasc

+ DCHECK(!in_process_event_types_.empty());

+ WebKit::WebInputEvent::Type event_type = in_process_event_types_.front();

+ if (WebKit::WebInputEvent::isMouseEventType(event_type))

+ type = content::MOUSE_CONTEXT_MENU;

+ else if (WebKit::WebInputEvent::isGestureEventType(event_type))

+ type = content::GESTURE_CONTEXT_MENU;

+ else if (WebKit::WebInputEvent::isKeyboardEventType(event_type))

+ type = content::KEYBOARD_CONTEXT_MENU;

+ delegate_->ShowContextMenu(validated_params, type);

}

void RenderViewHostImpl::OnMsgToggleFullscreen(bool enter_fullscreen) {