chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc - Issue 10917102: Context menus should appear above the touch point if invoked by long press.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

Issue 10917102: Context menus should appear above the touch point if invoked by long press. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.h ('k') | chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h » ('j') | content/browser/renderer_host/render_view_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

diff --git a/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc b/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

index e8cdc296baa1c066552bba043643f4920fa3deee..934244ce4ebee1aa32b12cdc7f6b911ac26a1f11 100644

--- a/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

+++ b/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

@@ -26,7 +26,8 @@ ChromeWebContentsViewDelegateAndroid::GetDragDestDelegate() {

}

void ChromeWebContentsViewDelegateAndroid::ShowContextMenu(

- const content::ContextMenuParams& params) {

+ const content::ContextMenuParams& params,

+ const content::ContextMenuEventType& type) {

// http://crbug.com/136075

NOTIMPLEMENTED();

// Still lacking some code here that depends on