Issue 10916294: switch html5lib to new pkg layout

Issue 10916294: switch html5lib to new pkg layout (Closed)

Created:
8 years, 3 months ago by Jennifer Messerly

Modified:
8 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/html5lib.git@master

Visibility:
Public.

More Reviews

Description

switch html5lib to new pkg layout

Patch Set 1 #

Created: 8 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+-14 lines, -37374 lines)			Patch
M	.gitignore	View	1 chunk	+1 line, -1 line	0 comments	Download
	README.md	View	5 chunks	+4 lines, -7 lines	0 comments	Download
D	html5parser.dart	View	1 chunk	+0 lines, -3264 lines	0 comments	Download
	lib/char_encodings.dart	View	1 chunk	+0 lines, -220 lines	0 comments	Download
	lib/constants.dart	View	1 chunk	+0 lines, -3151 lines	0 comments	Download
	lib/dom.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
D	lib/encoding_parser.dart	View	1 chunk	+0 lines, -383 lines	0 comments	Download
	lib/html5parser.dart	View	1 chunk	+8 lines, -6 lines	0 comments	Download
	lib/inputstream.dart	View	1 chunk	+0 lines, -433 lines	0 comments	Download
	lib/list_proxy.dart	View	1 chunk	+0 lines, -56 lines	0 comments	Download
	lib/src/char_encodings.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	lib/src/constants.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	lib/src/encoding_parser.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	lib/src/inputstream.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
A +	lib/src/list_proxy.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	lib/src/token.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	lib/src/treebuilder.dart	View	1 chunk	+6 lines, -6 lines	0 comments	Download
A +	lib/src/utils.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	lib/token.dart	View	1 chunk	+0 lines, -105 lines	0 comments	Download
	lib/tokenizer.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
D	lib/utils.dart	View	1 chunk	+0 lines, -190 lines	0 comments	Download
	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
	test/data/tokenizer/contentModelFlags.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tokenizer/domjs.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tokenizer/entities.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tokenizer/escapeFlag.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tokenizer/namedEntities.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tokenizer/numericEntities.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tokenizer/pendingSpecChanges.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tokenizer/test1.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tokenizer/test2.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tokenizer/test3.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tokenizer/test4.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tokenizer/unicodeChars.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tokenizer/unicodeCharsProblematic.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tokenizer/xmlViolation.test	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/adoption01.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/adoption02.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/comments01.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/doctype01.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/domjs-unsafe.dat	View	Binary file		0 comments	Download
	test/data/tree-construction/entities01.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/entities02.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/html5test-com.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/inbody01.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/isindex.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/pending-spec-changes.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/pending-spec-changes-plain-text-unsafe.dat	View	Binary file		0 comments	Download
A +	test/data/tree-construction/plain-text-unsafe.dat	View	Binary file		0 comments	Download
A +	test/data/tree-construction/scriptdata01.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/scripted/adoption01.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/scripted/ark.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/scripted/webkit01.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tables01.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests1.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests10.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests11.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests12.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests14.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests15.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests16.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests17.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests18.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests19.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests2.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests20.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests21.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests22.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests23.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests24.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests25.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests26.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests3.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests4.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests5.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests6.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests7.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests8.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/tests9.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tests_innerHTML_1.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/tricky01.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/data/tree-construction/webkit01.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/tree-construction/webkit02.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	test/parser_feature_test.dart	View	1 chunk	+5 lines, -5 lines	0 comments	Download
A +	test/parser_test.dart	View	1 chunk	+5 lines, -5 lines	0 comments	Download
A +	test/run.sh	View	1 chunk	+3 lines, -2 lines	0 comments	Download
	test/support.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	test/tokenizer_test.dart	View	1 chunk	+5 lines, -5 lines	0 comments	Download
	tests/data/tokenizer/contentModelFlags.test	View	1 chunk	+0 lines, -75 lines	0 comments	Download
D	tests/data/tokenizer/domjs.test	View	1 chunk	+0 lines, -90 lines	0 comments	Download
	tests/data/tokenizer/entities.test	View	1 chunk	+0 lines, -283 lines	0 comments	Download
D	tests/data/tokenizer/escapeFlag.test	View	1 chunk	+0 lines, -33 lines	0 comments	Download
	tests/data/tokenizer/numericEntities.test	View	1 chunk	+0 lines, -1313 lines	0 comments	Download
	tests/data/tokenizer/pendingSpecChanges.test	View	1 chunk	+0 lines, -7 lines	0 comments	Download
	tests/data/tokenizer/test1.test	View	1 chunk	+0 lines, -196 lines	0 comments	Download
	tests/data/tokenizer/test2.test	View	1 chunk	+0 lines, -179 lines	0 comments	Download
D	tests/data/tokenizer/test3.test	View	1 chunk	+0 lines, -6047 lines	0 comments	Download
D	tests/data/tokenizer/test4.test	View	1 chunk	+0 lines, -344 lines	0 comments	Download
	tests/data/tokenizer/unicodeChars.test	View	1 chunk	+0 lines, -1295 lines	0 comments	Download
D	tests/data/tokenizer/unicodeCharsProblematic.test	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	tests/data/tokenizer/xmlViolation.test	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	tests/data/tree-construction/adoption01.dat	View	1 chunk	+0 lines, -194 lines	0 comments	Download
D	tests/data/tree-construction/adoption02.dat	View	1 chunk	+0 lines, -31 lines	0 comments	Download
	tests/data/tree-construction/comments01.dat	View	1 chunk	+0 lines, -135 lines	0 comments	Download
D	tests/data/tree-construction/doctype01.dat	View	1 chunk	+0 lines, -370 lines	0 comments	Download
D	tests/data/tree-construction/domjs-unsafe.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	tests/data/tree-construction/entities01.dat	View	1 chunk	+0 lines, -603 lines	0 comments	Download
D	tests/data/tree-construction/entities02.dat	View	1 chunk	+0 lines, -249 lines	0 comments	Download
	tests/data/tree-construction/html5test-com.dat	View	1 chunk	+0 lines, -246 lines	0 comments	Download
D	tests/data/tree-construction/inbody01.dat	View	1 chunk	+0 lines, -43 lines	0 comments	Download
D	tests/data/tree-construction/isindex.dat	View	1 chunk	+0 lines, -40 lines	0 comments	Download
	tests/data/tree-construction/pending-spec-changes.dat	View	1 chunk	+0 lines, -52 lines	0 comments	Download
D	tests/data/tree-construction/pending-spec-changes-plain-text-unsafe.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	tests/data/tree-construction/plain-text-unsafe.dat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	tests/data/tree-construction/scriptdata01.dat	View	1 chunk	+0 lines, -308 lines	0 comments	Download
D	tests/data/tree-construction/scripted/adoption01.dat	View	1 chunk	+0 lines, -15 lines	0 comments	Download
D	tests/data/tree-construction/scripted/ark.dat	View	1 chunk	+0 lines, -26 lines	0 comments	Download
	tests/data/tree-construction/scripted/webkit01.dat	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	tests/data/tree-construction/tables01.dat	View	1 chunk	+0 lines, -212 lines	0 comments	Download
D	tests/data/tree-construction/tests1.dat	View	1 chunk	+0 lines, -1952 lines	0 comments	Download
	tests/data/tree-construction/tests10.dat	View	1 chunk	+0 lines, -799 lines	0 comments	Download
D	tests/data/tree-construction/tests11.dat	View	1 chunk	+0 lines, -482 lines	0 comments	Download
	tests/data/tree-construction/tests12.dat	View	1 chunk	+0 lines, -62 lines	0 comments	Download
D	tests/data/tree-construction/tests14.dat	View	1 chunk	+0 lines, -74 lines	0 comments	Download
	tests/data/tree-construction/tests15.dat	View	1 chunk	+0 lines, -208 lines	0 comments	Download
D	tests/data/tree-construction/tests16.dat	View	1 chunk	+0 lines, -2299 lines	0 comments	Download
	tests/data/tree-construction/tests17.dat	View	1 chunk	+0 lines, -153 lines	0 comments	Download
	tests/data/tree-construction/tests18.dat	View	1 chunk	+0 lines, -269 lines	0 comments	Download
D	tests/data/tree-construction/tests19.dat	View	1 chunk	+0 lines, -1237 lines	0 comments	Download
D	tests/data/tree-construction/tests2.dat	View	1 chunk	+0 lines, -763 lines	0 comments	Download
D	tests/data/tree-construction/tests20.dat	View	1 chunk	+0 lines, -455 lines	0 comments	Download
D	tests/data/tree-construction/tests21.dat	View	1 chunk	+0 lines, -221 lines	0 comments	Download
	tests/data/tree-construction/tests22.dat	View	1 chunk	+0 lines, -157 lines	0 comments	Download
D	tests/data/tree-construction/tests23.dat	View	1 chunk	+0 lines, -155 lines	0 comments	Download
D	tests/data/tree-construction/tests24.dat	View	1 chunk	+0 lines, -79 lines	0 comments	Download
D	tests/data/tree-construction/tests25.dat	View	1 chunk	+0 lines, -219 lines	0 comments	Download
	tests/data/tree-construction/tests26.dat	View	1 chunk	+0 lines, -313 lines	0 comments	Download
D	tests/data/tree-construction/tests3.dat	View	1 chunk	+0 lines, -305 lines	0 comments	Download
D	tests/data/tree-construction/tests4.dat	View	1 chunk	+0 lines, -59 lines	0 comments	Download
	tests/data/tree-construction/tests5.dat	View	1 chunk	+0 lines, -191 lines	0 comments	Download
D	tests/data/tree-construction/tests6.dat	View	1 chunk	+0 lines, -663 lines	0 comments	Download
	tests/data/tree-construction/tests7.dat	View	1 chunk	+0 lines, -390 lines	0 comments	Download
	tests/data/tree-construction/tests8.dat	View	1 chunk	+0 lines, -148 lines	0 comments	Download
D	tests/data/tree-construction/tests9.dat	View	1 chunk	+0 lines, -457 lines	0 comments	Download
D	tests/data/tree-construction/tests_innerHTML_1.dat	View	1 chunk	+0 lines, -741 lines	0 comments	Download
D	tests/data/tree-construction/tricky01.dat	View	1 chunk	+0 lines, -261 lines	0 comments	Download
D	tests/data/tree-construction/webkit01.dat	View	1 chunk	+0 lines, -594 lines	0 comments	Download
D	tests/data/tree-construction/webkit02.dat	View	1 chunk	+0 lines, -94 lines	0 comments	Download
	tests/parser_feature_test.dart	View	1 chunk	+0 lines, -69 lines	0 comments	Download
D	tests/parser_test.dart	View	1 chunk	+0 lines, -115 lines	0 comments	Download
	tests/run.sh	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	tests/support.dart	View	1 chunk	+0 lines, -179 lines	0 comments	Download
	tests/tokenizer_test.dart	View	1 chunk	+0 lines, -304 lines	0 comments	Download
	tokenizer.dart	View	1 chunk	+0 lines, -1804 lines	0 comments	Download
D	treebuilders/base.dart	View	1 chunk	+0 lines, -363 lines	0 comments	Download
D	treebuilders/simpletree.dart	View	1 chunk	+0 lines, -475 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

On 2012/09/13 20:22:04, John Messerly wrote: upload failed :(. See: https://github.com/dart-lang/html5lib/pull/18

8 years, 3 months ago (2012-09-13 20:23:36 UTC) #2

Siggi Cherem (dart-lang)

lgtm (see comments on pull requests though).

8 years, 3 months ago (2012-09-13 20:27:46 UTC) #3

Jennifer Messerly

8 years, 3 months ago (2012-09-13 21:00:20 UTC) #4

On 2012/09/13 20:27:46, sigmund wrote:
> lgtm (see comments on pull requests though).

committed in
https://github.com/dart-lang/html5lib/commit/bc918cb428461ef83215b5eafc3fc3bd...

Expand Messages | Collapse Messages