Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3823)

Unified Diff: lib/mirrors/mirrors.dart

Issue 10916252: Implement more of the mirrors library, primarily stuff to do with types. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/include/dart_api.h » ('j') | runtime/include/dart_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/mirrors/mirrors.dart
===================================================================
--- lib/mirrors/mirrors.dart (revision 11702)
+++ lib/mirrors/mirrors.dart (working copy)
@@ -401,13 +401,17 @@
/**
* A list of type variables for this type.
+ *
+ * This map preserves the order of declaration of the type variables.
cshapiro 2012/09/12 18:52:07 I am not sure I understand the value of this comme
turnidge 2012/09/12 21:39:30 Since maps are not by default ordered, this commen
*/
- final List<TypeVariableMirror> typeVariables;
+ final Map<String, TypeVariableMirror> typeVariables;
/**
* A list of the type arguments for this type.
+ *
+ * This map preserves the order of declaration of the type variables.
cshapiro 2012/09/12 18:52:07 Same here as above.
*/
- final List<TypeMirror> typeArguments;
+ final Map<String, TypeMirror> typeArguments;
/**
* Is this the original declaration of this type?
@@ -458,21 +462,10 @@
}
/**
- * A [TypeVariableMirror] represents a type parameter of a generic
- * type.
- */
-interface TypeVariableMirror extends TypeMirror {
- /**
- * A mirror on the type that is the upper bound for this type variable.
- */
- final TypeMirror upperBound;
-}
-
-/**
* A [FunctionTypeMirror] represents the type of a function in the
* Dart language.
*/
-interface FunctionTypeMirror extends TypeMirror {
+interface FunctionTypeMirror extends ClassMirror {
/**
* The return type of the reflectee.
*/
@@ -492,15 +485,26 @@
}
/**
+ * A [TypeVariableMirror] represents a type parameter of a generic
+ * type.
+ */
+interface TypeVariableMirror extends TypeMirror {
+ /**
+ * A mirror on the type that is the upper bound for this type variable.
cshapiro 2012/09/12 18:52:07 Maybe "of this type variable" instead of "for this
turnidge 2012/09/12 21:39:30 Done.
+ */
+ final TypeMirror upperBound;
+}
+
+/**
* A [TypedefMirror] represents a typedef in a Dart language program.
*/
-interface TypedefMirror extends ClassMirror {
+interface TypedefMirror extends TypeMirror {
/**
* The defining type for this typedef.
*
* For instance [:void f(int):] is the value for [:typedef void f(int):].
*/
- final TypeMirror value;
+ final TypeMirror referent;
}
/**
« no previous file with comments | « no previous file | runtime/include/dart_api.h » ('j') | runtime/include/dart_api.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698