Implement more of the mirrors library, primarily stuff to do with types.

lib/mirrors/mirrors.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // The dart:mirrors library provides reflective access for Dart program.
 //
 // For the purposes of the mirrors library, we adopt a naming
 // convention with respect to getters and setters.  Specifically, for
 // some variable or field...
 //
@@ skipping 383 matching lines @@
   final Map<String, MethodMirror> setters;
 
   /**
    * An immutable map from names to mirrors for all variable
    * declarations for this type.
    */
   final Map<String, VariableMirror> variables;
 
   /**
    * A list of type variables for this type.
+   *
+   * This map preserves the order of declaration of the type variables.

[cshapiro, 2012/09/12 18:52:07]

I am not sure I understand the value of this comment.  Lists and maps are both
order preserving, so what is the point of mentioning it?  Also, the comment on
line 403 did not change, so I am having trouble with the big picture.

[turnidge, 2012/09/12 21:39:30]

Since maps are not by default ordered, this comment is required.  Another option
would be to have something like an OrderedMap, if that existed.

I've added a comment in mirrors.cc to actually use an ordered map, which I
current do not.

    */
-  final List<TypeVariableMirror> typeVariables;
+  final Map<String, TypeVariableMirror> typeVariables;
 
   /**
    * A list of the type arguments for this type.
+   *
+   * This map preserves the order of declaration of the type variables.

[cshapiro, 2012/09/12 18:52:07]

Same here as above.

    */
-  final List<TypeMirror> typeArguments;
+  final Map<String, TypeMirror> typeArguments;
 
   /**
    * Is this the original declaration of this type?
    *
    * For most classes, they are their own original declaration.  For
    * generic classes, however, there is a distinction between the
    * original class declaration, which has unbound type variables, and
    * the instantiations of generic classes, which have bound type
    * variables.
    */
@@ skipping 30 matching lines @@
   /**
    * A mirror on the default factory class or null if there is none.
    *
    * TODO(turnidge): This functions goes away after the
    * class/interface changes.
    */
   final ClassMirror defaultFactory;
 }
 
 /**
- * A [TypeVariableMirror] represents a type parameter of a generic
- * type.
- */
-interface TypeVariableMirror extends TypeMirror {
-  /**
-   * A mirror on the type that is the upper bound for this type variable.
-   */
-  final TypeMirror upperBound;
-}
-
-/**
  * A [FunctionTypeMirror] represents the type of a function in the
  * Dart language.
  */
-interface FunctionTypeMirror extends TypeMirror {
+interface FunctionTypeMirror extends ClassMirror {
   /**
    * The return type of the reflectee.
    */
   final TypeMirror returnType;
 
   /**
    * A list of the parameter types of the reflectee.
    */
   final List<ParameterMirror> parameters;
 
   /**
    * A mirror on the [:call:] method for the reflectee.
    *
    * TODO(turnidge): What is this and what is it for?
    */
   final MethodMirror callMethod;
 }
 
 /**
+ * A [TypeVariableMirror] represents a type parameter of a generic
+ * type.
+ */
+interface TypeVariableMirror extends TypeMirror {
+  /**
+   * A mirror on the type that is the upper bound for this type variable.

[cshapiro, 2012/09/12 18:52:07]

Maybe "of this type variable" instead of "for this..." ?

[turnidge, 2012/09/12 21:39:30]

Done.

+   */
+  final TypeMirror upperBound;
+}
+
+/**
  * A [TypedefMirror] represents a typedef in a Dart language program.
  */
-interface TypedefMirror extends ClassMirror {
+interface TypedefMirror extends TypeMirror {
   /**
    * The defining type for this typedef.
    *
    * For instance [:void f(int):] is the value for [:typedef void f(int):].
    */
-  final TypeMirror value;
+  final TypeMirror referent;
 }
 
 /**
  * A [MethodMirror] reflects a Dart language function, method,
  * constructor, getter, or setter.
  */
 interface MethodMirror extends DeclarationMirror {
   /**
    * A mirror on the return type for the reflectee.
    */
@@ skipping 214 matching lines @@
 
 /**
  * A [MirrorException] is used to indicate errors within the mirrors
  * framework.
  */
 class MirrorException implements Exception {
   const MirrorException(String this._message);
   String toString() => "MirrorException: '$_message'";
   final String _message;
 }