Chromium Code Reviews| Index: lib/mirrors/mirrors.dart |
| =================================================================== |
| --- lib/mirrors/mirrors.dart (revision 11702) |
| +++ lib/mirrors/mirrors.dart (working copy) |
| @@ -401,13 +401,17 @@ |
| /** |
| * A list of type variables for this type. |
| + * |
| + * This map preserves the order of declaration of the type variables. |
|
cshapiro
2012/09/12 18:52:07
I am not sure I understand the value of this comme
turnidge
2012/09/12 21:39:30
Since maps are not by default ordered, this commen
|
| */ |
| - final List<TypeVariableMirror> typeVariables; |
| + final Map<String, TypeVariableMirror> typeVariables; |
| /** |
| * A list of the type arguments for this type. |
| + * |
| + * This map preserves the order of declaration of the type variables. |
|
cshapiro
2012/09/12 18:52:07
Same here as above.
|
| */ |
| - final List<TypeMirror> typeArguments; |
| + final Map<String, TypeMirror> typeArguments; |
| /** |
| * Is this the original declaration of this type? |
| @@ -458,21 +462,10 @@ |
| } |
| /** |
| - * A [TypeVariableMirror] represents a type parameter of a generic |
| - * type. |
| - */ |
| -interface TypeVariableMirror extends TypeMirror { |
| - /** |
| - * A mirror on the type that is the upper bound for this type variable. |
| - */ |
| - final TypeMirror upperBound; |
| -} |
| - |
| -/** |
| * A [FunctionTypeMirror] represents the type of a function in the |
| * Dart language. |
| */ |
| -interface FunctionTypeMirror extends TypeMirror { |
| +interface FunctionTypeMirror extends ClassMirror { |
| /** |
| * The return type of the reflectee. |
| */ |
| @@ -492,15 +485,26 @@ |
| } |
| /** |
| + * A [TypeVariableMirror] represents a type parameter of a generic |
| + * type. |
| + */ |
| +interface TypeVariableMirror extends TypeMirror { |
| + /** |
| + * A mirror on the type that is the upper bound for this type variable. |
|
cshapiro
2012/09/12 18:52:07
Maybe "of this type variable" instead of "for this
turnidge
2012/09/12 21:39:30
Done.
|
| + */ |
| + final TypeMirror upperBound; |
| +} |
| + |
| +/** |
| * A [TypedefMirror] represents a typedef in a Dart language program. |
| */ |
| -interface TypedefMirror extends ClassMirror { |
| +interface TypedefMirror extends TypeMirror { |
| /** |
| * The defining type for this typedef. |
| * |
| * For instance [:void f(int):] is the value for [:typedef void f(int):]. |
| */ |
| - final TypeMirror value; |
| + final TypeMirror referent; |
| } |
| /** |