Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 10916221: Make ToplevelWindowEventFilter and WorkspaceEventFilter into event handlers. (Closed)

Created:
8 years, 3 months ago by Ben Goodger (Google)
Modified:
8 years, 3 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Make ToplevelWindowEventFilter and WorkspaceEventFilter into event handlers. http://crbug.com/147653 R=sky@chromium.org,sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155940

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -1639 lines) Patch
M ash/ash.gyp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M ash/root_window_controller.cc View 1 5 chunks +11 lines, -9 lines 0 comments Download
M ash/shell.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ash/shell_unittest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
D ash/wm/toplevel_window_event_filter.h View 1 1 chunk +0 lines, -106 lines 0 comments Download
D ash/wm/toplevel_window_event_filter.cc View 1 1 chunk +0 lines, -376 lines 0 comments Download
D ash/wm/toplevel_window_event_filter_unittest.cc View 1 1 chunk +0 lines, -491 lines 0 comments Download
A + ash/wm/toplevel_window_event_handler.h View 1 4 chunks +15 lines, -20 lines 0 comments Download
A + ash/wm/toplevel_window_event_handler.cc View 1 14 chunks +53 lines, -46 lines 0 comments Download
A + ash/wm/toplevel_window_event_handler_unittest.cc View 1 27 chunks +34 lines, -34 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace2.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace2.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
D ash/wm/workspace/workspace_event_filter.h View 1 1 chunk +0 lines, -60 lines 0 comments Download
D ash/wm/workspace/workspace_event_filter.cc View 1 1 chunk +0 lines, -170 lines 0 comments Download
D ash/wm/workspace/workspace_event_filter_test_helper.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
D ash/wm/workspace/workspace_event_filter_test_helper.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download
D ash/wm/workspace/workspace_event_filter_unittest.cc View 1 1 chunk +0 lines, -171 lines 0 comments Download
A + ash/wm/workspace/workspace_event_handler.h View 1 3 chunks +14 lines, -17 lines 0 comments Download
A + ash/wm/workspace/workspace_event_handler.cc View 1 5 chunks +13 lines, -14 lines 0 comments Download
A + ash/wm/workspace/workspace_event_handler_test_helper.h View 1 1 chunk +10 lines, -10 lines 0 comments Download
A + ash/wm/workspace/workspace_event_handler_test_helper.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + ash/wm/workspace/workspace_event_handler_unittest.cc View 1 7 chunks +11 lines, -11 lines 0 comments Download
M ash/wm/workspace_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace_controller.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/workspace_controller_test_helper.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller_test_helper.cc View 1 2 chunks +9 lines, -7 lines 0 comments Download
M ui/base/events/event_target.h View 1 3 chunks +16 lines, -4 lines 0 comments Download
M ui/base/events/event_target.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
8 years, 3 months ago (2012-09-10 23:25:52 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-09-10 23:30:46 UTC) #2
sadrul
8 years, 3 months ago (2012-09-10 23:40:11 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698