Issue 10916078: Remove the is_used_ field from BindInstr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10916078: Remove the is_used_ field from BindInstr. (Closed)

Created:
8 years, 3 months ago by Kevin Millikin (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider, zerny-google

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove the is_used_ field from BindInstr. Also, refactor the way that we implement predicates to define IsXXX in terms of AsXXX. The code assumes pervasively that IsXXX implies that AsXXX returns non-NULL. R=fschneider@google.com,zerny@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11768

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -53 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	11 chunks	+14 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	12 chunks	+40 lines, -33 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

zerny-google

8 years, 3 months ago (2012-09-03 13:33:22 UTC) #3

lgtm, but why can we not get rid of is_used entirely? (Or rephrase it in terms
of the use lists).