Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 10915304: We do not pass enums by conts references. This CL fixes style errors introduced (Closed)

Created:
8 years, 3 months ago by varunjain
Modified:
8 years, 3 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, tfarina, jam, darin-cc_chromium.org
Visibility:
Public.

Description

We do not pass enums by conts references. This CL fixes style errors introduced in a previous CL. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/interstitial_page_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/interstitial_page_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/port/browser/render_view_host_delegate_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_view_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_web_contents_view_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_web_contents_view_delegate_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_web_contents_view_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_web_contents_view_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_web_contents_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_web_contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
varunjain
8 years, 3 months ago (2012-09-17 03:58:55 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-09-17 14:32:50 UTC) #2
jam
content lgtm
8 years, 3 months ago (2012-09-17 19:32:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10915304/1
8 years, 3 months ago (2012-09-17 19:37:06 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-17 19:40:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10915304/1
8 years, 3 months ago (2012-09-17 20:34:11 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-17 21:37:29 UTC) #7
Change committed as 157205

Powered by Google App Engine
This is Rietveld 408576698