Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2032)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 10915304: We do not pass enums by conts references. This CL fixes style errors introduced (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 1412 matching lines...) Expand 10 before | Expand all | Expand 10 after
1423 if (!widget_host->GetProcess()->HasConnection()) { 1423 if (!widget_host->GetProcess()->HasConnection()) {
1424 // The view has gone away or the renderer crashed. Nothing to do. 1424 // The view has gone away or the renderer crashed. Nothing to do.
1425 return NULL; 1425 return NULL;
1426 } 1426 }
1427 1427
1428 return widget_host_view; 1428 return widget_host_view;
1429 } 1429 }
1430 1430
1431 void WebContentsImpl::ShowContextMenu( 1431 void WebContentsImpl::ShowContextMenu(
1432 const content::ContextMenuParams& params, 1432 const content::ContextMenuParams& params,
1433 const content::ContextMenuSourceType& type) { 1433 content::ContextMenuSourceType type) {
1434 // Allow WebContentsDelegates to handle the context menu operation first. 1434 // Allow WebContentsDelegates to handle the context menu operation first.
1435 if (delegate_ && delegate_->HandleContextMenu(params)) 1435 if (delegate_ && delegate_->HandleContextMenu(params))
1436 return; 1436 return;
1437 1437
1438 render_view_host_delegate_view_->ShowContextMenu(params, type); 1438 render_view_host_delegate_view_->ShowContextMenu(params, type);
1439 } 1439 }
1440 1440
1441 void WebContentsImpl::RequestMediaAccessPermission( 1441 void WebContentsImpl::RequestMediaAccessPermission(
1442 const content::MediaStreamRequest* request, 1442 const content::MediaStreamRequest* request,
1443 const content::MediaResponseCallback& callback) { 1443 const content::MediaResponseCallback& callback) {
(...skipping 1843 matching lines...) Expand 10 before | Expand all | Expand 10 after
3287 old_browser_plugin_host()->embedder_render_process_host(); 3287 old_browser_plugin_host()->embedder_render_process_host();
3288 *embedder_container_id = old_browser_plugin_host()->instance_id(); 3288 *embedder_container_id = old_browser_plugin_host()->instance_id();
3289 int embedder_process_id = 3289 int embedder_process_id =
3290 embedder_render_process_host ? embedder_render_process_host->GetID() : -1; 3290 embedder_render_process_host ? embedder_render_process_host->GetID() : -1;
3291 if (embedder_process_id != -1) { 3291 if (embedder_process_id != -1) {
3292 *embedder_channel_name = 3292 *embedder_channel_name =
3293 StringPrintf("%d.r%d", render_view_host->GetProcess()->GetID(), 3293 StringPrintf("%d.r%d", render_view_host->GetProcess()->GetID(),
3294 embedder_process_id); 3294 embedder_process_id);
3295 } 3295 }
3296 } 3296 }
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/browser/web_contents/web_contents_view_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698