Add capability for GPU blacklist to manage GPU switching.

Add capability for GPU blacklist to manage GPU switching.

This is orthorgonal to the blacklist feature management.

Doing this, we don't have to hardwire the forcing on discrete GPU for the new Macbook 2012; also, we provide a way for users to bypass the forcing (use --ignore-gpu-blacklist).

Note that this CL implements it in the GPU blacklist.  We haven't hooked it up to the real GPU switching yet (will do it in another CL).

BUG=140114, 131276, 111720
TEST=tree
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156326

[Zhenyao Mo, 2012-09-12 00:18:53]

kbr: can you review this?
jbauman: FYI

[Ken Russell (switch to Gerrit), 2012-09-12 01:59:03]

LGTM. Thanks for doing this.

http://codereview.chromium.org/10915219/diff/1/content/browser/gpu/gpu_blackl...
File content/browser/gpu/gpu_blacklist.h (right):

http://codereview.chromium.org/10915219/diff/1/content/browser/gpu/gpu_blackl...
content/browser/gpu/gpu_blacklist.h:68: Decision MakeBlacklistDecision(
Thank you for renaming this. The old name was very confusing.

http://codereview.chromium.org/10915219/diff/1/content/browser/gpu/gpu_blackl...
content/browser/gpu/gpu_blacklist.h:397: // called and is used later by
GetDecisionEntries() and
Incomplete sentence.

http://codereview.chromium.org/10915219/diff/1/content/browser/gpu/gpu_blackl...
File content/browser/gpu/gpu_blacklist_unittest.cc (right):

http://codereview.chromium.org/10915219/diff/1/content/browser/gpu/gpu_blackl...
content/browser/gpu/gpu_blacklist_unittest.cc:1023: EXPECT_EQ(switching,
content::GPU_SWITCHING_FORCE_DISCRETE);
Please also test the force_integrated and automatic gpu_switching values.

[Zhenyao Mo, 2012-09-12 17:41:33]

https://chromiumcodereview.appspot.com/10915219/diff/1/content/browser/gpu/gp...
File content/browser/gpu/gpu_blacklist.h (right):

https://chromiumcodereview.appspot.com/10915219/diff/1/content/browser/gpu/gp...
content/browser/gpu/gpu_blacklist.h:397: // called and is used later by
GetDecisionEntries() and
On 2012/09/12 01:59:04, kbr wrote:
> Incomplete sentence.

Done.

https://chromiumcodereview.appspot.com/10915219/diff/1/content/browser/gpu/gp...
File content/browser/gpu/gpu_blacklist_unittest.cc (right):

https://chromiumcodereview.appspot.com/10915219/diff/1/content/browser/gpu/gp...
content/browser/gpu/gpu_blacklist_unittest.cc:1023: EXPECT_EQ(switching,
content::GPU_SWITCHING_FORCE_DISCRETE);
On 2012/09/12 01:59:04, kbr wrote:
> Please also test the force_integrated and automatic gpu_switching values.

Done.

[jam, 2012-09-12 19:36:19]

http://codereview.chromium.org/10915219/diff/16/content/public/common/gpu_fea...
File content/public/common/gpu_feature_type.h (right):

http://codereview.chromium.org/10915219/diff/16/content/public/common/gpu_fea...
content/public/common/gpu_feature_type.h:34: enum GpuSwitchingOption {
nit: this needs to be in a separate file, also the naming has to be
GPU_SWITCHING_OPTION_AUTOMATIC, GPU_SWITCHING_OPTION_FORCE_INTEGRATED etc

[Zhenyao Mo, 2012-09-12 20:56:29]

On 2012/09/12 19:36:19, John Abd-El-Malek wrote:
>
http://codereview.chromium.org/10915219/diff/16/content/public/common/gpu_fea...
> File content/public/common/gpu_feature_type.h (right):
> 
>
http://codereview.chromium.org/10915219/diff/16/content/public/common/gpu_fea...
> content/public/common/gpu_feature_type.h:34: enum GpuSwitchingOption {
> nit: this needs to be in a separate file, also the naming has to be
> GPU_SWITCHING_OPTION_AUTOMATIC, GPU_SWITCHING_OPTION_FORCE_INTEGRATED etc

Thanks.  Will make the changes in a followup CL as I already committed this one.

[jam, 2012-09-13 01:25:47]

On 2012/09/12 20:56:29, Zhenyao Mo wrote:
> On 2012/09/12 19:36:19, John Abd-El-Malek wrote:
> >
>
http://codereview.chromium.org/10915219/diff/16/content/public/common/gpu_fea...
> > File content/public/common/gpu_feature_type.h (right):
> > 
> >
>
http://codereview.chromium.org/10915219/diff/16/content/public/common/gpu_fea...
> > content/public/common/gpu_feature_type.h:34: enum GpuSwitchingOption {
> > nit: this needs to be in a separate file, also the naming has to be
> > GPU_SWITCHING_OPTION_AUTOMATIC, GPU_SWITCHING_OPTION_FORCE_INTEGRATED etc
> 
> Thanks.  Will make the changes in a followup CL as I already committed this
one.

this shouldn't have been committed in the first place. why did you override
owners check by forcing the commit? i see a bunch of other checkins from you to
content/public with no owner review