In preparation for lazy deoptimization add "is_alive_" field to RawCode: visit embedded pointers on…

runtime/vm/raw_object.cc

Index: runtime/vm/raw_object.cc
===================================================================
--- runtime/vm/raw_object.cc	(revision 11927)
+++ runtime/vm/raw_object.cc	(working copy)
@@ -435,14 +435,17 @@
                                     ObjectPointerVisitor* visitor) {
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
 
-  // Also visit all the embedded pointers in the corresponding instructions.
   RawCode* obj = raw_obj->ptr();
   intptr_t length = obj->pointer_offsets_length_;
-  uword entry_point = reinterpret_cast<uword>(obj->instructions_->ptr()) +
-      Instructions::HeaderSize();
-  for (intptr_t i = 0; i < length; i++) {
-    int32_t offset = obj->data_[i];
-    visitor->VisitPointer(reinterpret_cast<RawObject**>(entry_point + offset));
+  if (obj->is_alive_ == 1) {
+    // Also visit all the embedded pointers in the corresponding instructions.
+    uword entry_point = reinterpret_cast<uword>(obj->instructions_->ptr()) +
+        Instructions::HeaderSize();
+    for (intptr_t i = 0; i < length; i++) {
+      int32_t offset = obj->data_[i];
+      visitor->VisitPointer(
+          reinterpret_cast<RawObject**>(entry_point + offset));
+    }
   }

[siva, 2012/09/06 16:57:55]

I am assuming the change to mark an object as not alive is still pending.

[srdjan, 2012/09/06 17:06:03]

Correct.

   return Code::InstanceSize(length);
 }