In preparation for lazy deoptimization add "is_alive_" field to RawCode: visit embedded pointers on…

runtime/vm/raw_object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/raw_object.h"
 
 #include "vm/class_table.h"
 #include "vm/freelist.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
@@ skipping 417 matching lines @@
     RawLibraryPrefix* raw_obj, ObjectPointerVisitor* visitor) {
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
   return LibraryPrefix::InstanceSize();
 }
 
 
 intptr_t RawCode::VisitCodePointers(RawCode* raw_obj,
                                     ObjectPointerVisitor* visitor) {
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
 
-  // Also visit all the embedded pointers in the corresponding instructions.
   RawCode* obj = raw_obj->ptr();
   intptr_t length = obj->pointer_offsets_length_;
-  uword entry_point = reinterpret_cast<uword>(obj->instructions_->ptr()) +
-      Instructions::HeaderSize();
-  for (intptr_t i = 0; i < length; i++) {
-    int32_t offset = obj->data_[i];
-    visitor->VisitPointer(reinterpret_cast<RawObject**>(entry_point + offset));
+  if (obj->is_alive_ == 1) {
+    // Also visit all the embedded pointers in the corresponding instructions.
+    uword entry_point = reinterpret_cast<uword>(obj->instructions_->ptr()) +
+        Instructions::HeaderSize();
+    for (intptr_t i = 0; i < length; i++) {
+      int32_t offset = obj->data_[i];
+      visitor->VisitPointer(
+          reinterpret_cast<RawObject**>(entry_point + offset));
+    }
   }

[siva, 2012/09/06 16:57:55]

I am assuming the change to mark an object as not alive is still pending.

[srdjan, 2012/09/06 17:06:03]

Correct.

   return Code::InstanceSize(length);
 }
 
 
 intptr_t RawInstructions::VisitInstructionsPointers(
     RawInstructions* raw_obj, ObjectPointerVisitor* visitor) {
   RawInstructions* obj = raw_obj->ptr();
   visitor->VisitPointer(reinterpret_cast<RawObject**>(&obj->code_));
   return Instructions::InstanceSize(obj->size_);
 }
@@ skipping 521 matching lines @@
 
 intptr_t RawWeakProperty::VisitWeakPropertyPointers(
     RawWeakProperty* raw_obj, ObjectPointerVisitor* visitor) {
   // Make sure that we got here with the tagged pointer as this.
   ASSERT(raw_obj->IsHeapObject());
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
   return WeakProperty::InstanceSize();
 }
 
 }  // namespace dart