Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: ui/base/native_theme/native_theme_win.cc

Issue 10915065: Add PlatformPictureSkia and RecordingPlatformDeviceSkia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: And one more.. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/skia.gyp ('k') | ui/gfx/blit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/native_theme/native_theme_win.cc
diff --git a/ui/base/native_theme/native_theme_win.cc b/ui/base/native_theme/native_theme_win.cc
index 92fd382c1434723e219eb14830f0d53dd570689a..3b0c94cc80f1d10123a002b7d45b208c42dc38ab 100644
--- a/ui/base/native_theme/native_theme_win.cc
+++ b/ui/base/native_theme/native_theme_win.cc
@@ -288,7 +288,8 @@ void NativeThemeWin::Paint(SkCanvas* canvas,
const gfx::Rect& rect,
const ExtraParams& extra) const {
bool needs_paint_indirect = false;
- if (!skia::SupportsPlatformPaint(canvas)) {
+ if (skia::PlatformPaintSupport(canvas) !=
+ skia::PlatformDevice::PLATFORM_PAINT_DIRECT) {
// This block will only get hit with --enable-accelerated-drawing flag.
needs_paint_indirect = true;
} else {
@@ -483,7 +484,7 @@ void NativeThemeWin::PaintIndirect(SkCanvas* canvas,
scoped_ptr<SkCanvas> offscreen_canvas(
skia::CreateBitmapCanvas(rect.width(), rect.height(), false));
DCHECK(offscreen_canvas.get());
reed1 2012/09/25 11:53:59 shouldn't we DCHECK against one or more enum value
reveman 2012/09/25 12:04:13 I explicitly made PLATFORM_PAINT_UNSUPPORTED = 0 s
- DCHECK(skia::SupportsPlatformPaint(offscreen_canvas.get()));
+ DCHECK(skia::PlatformPaintSupport(offscreen_canvas.get()));
// Some of the Windows theme drawing operations do not write correct alpha
// values for fully-opaque pixels; instead the pixels get alpha 0. This is
« no previous file with comments | « skia/skia.gyp ('k') | ui/gfx/blit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698