Add PlatformPictureSkia and RecordingPlatformDeviceSkia.

ui/base/native_theme/native_theme_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/native_theme/native_theme_win.h"
 
 #include <windows.h>
 #include <uxtheme.h>
 #include <vsstyle.h>
 #include <vssym32.h>
@@ skipping 270 matching lines @@
 
   return gfx::Size(size.cx, size.cy);
 }
 
 void NativeThemeWin::Paint(SkCanvas* canvas,
                            Part part,
                            State state,
                            const gfx::Rect& rect,
                            const ExtraParams& extra) const {
   bool needs_paint_indirect = false;
-  if (!skia::SupportsPlatformPaint(canvas)) {
+  if (skia::PlatformPaintSupport(canvas) !=
+      skia::PlatformDevice::PLATFORM_PAINT_DIRECT) {
     // This block will only get hit with --enable-accelerated-drawing flag.
     needs_paint_indirect = true;
   } else {
     // Scrollbars on Windows XP and the Windows Classic theme have particularly
     // problematic alpha values, so always draw them indirectly.
     switch (part) {
       case kScrollbarDownArrow:
       case kScrollbarUpArrow:
       case kScrollbarLeftArrow:
       case kScrollbarRightArrow:
@@ skipping 173 matching lines @@
                                    const gfx::Rect& rect,
                                    const ExtraParams& extra) const {
   // TODO(asvitkine): This path is pretty inefficient - for each paint operation
   //                  it creates a new offscreen bitmap Skia canvas. This can
   //                  be sped up by doing it only once per part/state and
   //                  keeping a cache of the resulting bitmaps.
 
   // Create an offscreen canvas that is backed by an HDC.
   scoped_ptr<SkCanvas> offscreen_canvas(
       skia::CreateBitmapCanvas(rect.width(), rect.height(), false));
   DCHECK(offscreen_canvas.get());

[reed1, 2012/09/25 11:53:59]

shouldn't we DCHECK against one or more enum values here, instead of relying on
passive conversion to bool?

[reveman, 2012/09/25 12:04:13]

I explicitly made PLATFORM_PAINT_UNSUPPORTED = 0 so code that doesn't care about
the paint type can do this check.

I can change this to an explicit enum value check if you prefer that?

-  DCHECK(skia::SupportsPlatformPaint(offscreen_canvas.get()));
+  DCHECK(skia::PlatformPaintSupport(offscreen_canvas.get()));
 
   // Some of the Windows theme drawing operations do not write correct alpha
   // values for fully-opaque pixels; instead the pixels get alpha 0. This is
   // especially a problem on Windows XP or when using the Classic theme.
   //
   // To work-around this, mark all pixels with a placeholder value, to detect
   // which pixels get touched by the paint operation. After paint, set any
   // pixels that have alpha 0 to opaque and placeholders to fully-transparent.
   const SkColor placeholder = SkColorSetARGB(1, 0, 0, 0);
   offscreen_canvas->clear(placeholder);
@@ skipping 1312 matching lines @@
     handle = open_theme_(NULL, L"Spin");
     break;
   default:
     NOTREACHED();
   }
   theme_handles_[theme_name] = handle;
   return handle;
 }
 
 }  // namespace ui