Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 10915003: Remove Pipeline::has_{audio,video}_ members. (Closed)

Created:
8 years, 3 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove Pipeline::has_{audio,video}_ members.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M media/base/pipeline.h View 2 chunks +1 line, -7 lines 0 comments Download
M media/base/pipeline.cc View 9 chunks +10 lines, -13 lines 1 comment Download
M media/base/pipeline_unittest.cc View 7 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ami GONE FROM CHROMIUM
Last plane-flavored CL before getting on a plane, I promise! https://chromiumcodereview.appspot.com/10915003/diff/1/media/base/pipeline.cc File media/base/pipeline.cc (right): https://chromiumcodereview.appspot.com/10915003/diff/1/media/base/pipeline.cc#newcode671 ...
8 years, 3 months ago (2012-08-30 07:09:10 UTC) #1
scherkus (not reviewing)
let's talk more tomorrow but the reason I didn't do this in http://codereview.chromium.org/10837206 was because ...
8 years, 3 months ago (2012-08-30 07:23:42 UTC) #2
Ami GONE FROM CHROMIUM
8 years, 3 months ago (2012-09-02 09:40:27 UTC) #3
(per offline convo w/ scherkus)

This change explicates the existing races (e.g. between has_audio_ being set and
audio_renderer_ being dropped, and so on).

But actually it's crazy that we even have Has{Audio,Video}()!  Instead, the
presence of each type of track should be reported as part of Pipeline's
end-of-initialization callback.  Probably best to have a separate
enum TrackType { AUDIO, VIDEO };
typedef base::Callback<void(TrackType)> HaveTrackCB;
passed to Pipeline::Start, which is used to report the presence of tracks to
WMPI, which will cache as needed to report has{Audio,Video}() to webkit later.

Closing this CL in favor of that approach.

Powered by Google App Engine
This is Rietveld 408576698