Issue 10914293: Part one of Converting DOMList types like FooList to List<Foo>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10914293: Part one of Converting DOMList types like FooList to List<Foo>. (Closed)

Created:
8 years, 3 months ago by Emily Fortuna

Modified:
6 years, 10 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Part one of Converting DOMList types like FooList to List<Foo>. This makes the immutable list types actually inherit from list, but to actually make the FooList types invisible to the user is going to take a lot more work. Additionally "lists" with extra methods will need to be unified for consistency. Committed: https://code.google.com/p/dart/source/detail?r=12414

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2334 lines, -35 lines)			Patch
M	lib/html/dartium/html_dartium.dart	View		54 chunks	+2239 lines, -29 lines	0 comments	Download
M	lib/html/idl/dart/dart.idl	View	1 2 3	2 chunks	+49 lines, -1 line	0 comments	Download
A	tests/html/client_rect_test.dart	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
A	tests/html/css_rule_list_test.dart	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1 2 3	2 chunks	+0 lines, -2 lines	0 comments	Download
M	tests/html/svg_3_test.dart	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/html/typing_test.dart	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

This area could stand to add some more tests. I'll work on adding some tests ...

8 years, 3 months ago (2012-09-14 16:54:19 UTC) #1

vsm

8 years, 3 months ago (2012-09-14 22:39:01 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10914293/diff/3008/lib/html/idl/dart/d...
File lib/html/idl/dart/dart.idl (right):

https://chromiumcodereview.appspot.com/10914293/diff/3008/lib/html/idl/dart/d...
lib/html/idl/dart/dart.idl:8: //DataTransferItemList implements
sequence<DataTransferItem>; mutable
Can you drop the commented out types into the TODO list below?

Expand Messages | Collapse Messages