Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10914284: Rename chrome.fileSystem apis to be expandable to directories if we wish. (Closed)

Created:
8 years, 3 months ago by benwells
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, kinuko+watch, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, tzik+watch_chromium.org, thorogood
Visibility:
Public.

Description

Rename chrome.fileSystem apis to be expandable to directories if we wish. The naming is currently all about files, this change makes it file / directory neutral to allow us to use the same APIs for directories at some point if we decide to. BUG=149152 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156795

Patch Set 1 #

Patch Set 2 : Removed blank line #

Total comments: 1

Patch Set 3 : Fix unit tests #

Patch Set 4 : With feedback from Mihai #

Patch Set 5 : Updated comment to be a TODO #

Patch Set 6 : Rebase #

Patch Set 7 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -107 lines) Patch
M chrome/browser/extensions/api/file_system/file_system_api.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 2 3 4 5 12 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api_unittest.cc View 1 2 10 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest.cc View 15 chunks +19 lines, -19 lines 0 comments Download
M chrome/common/extensions/api/file_system.idl View 1 2 3 4 5 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/articles/app_storage.html View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/file_system_custom_bindings.js View 1 2 3 4 2 chunks +21 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system/get_display_path/test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/get_display_path_prettify/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/get_writable_file_entry/test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system/get_writable_file_entry_with_write/test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system/get_writable_file_entry_with_write/test_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/invalid_choose_file_type/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/is_writable_file_entry/test.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system/open_background/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/open_cancel/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/open_existing/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/open_existing/test_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/open_existing_with_write/test.js View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/open_existing_with_write/test_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/open_writable_existing/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/open_writable_existing_with_write/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/open_writable_existing_with_write/test_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/save_background/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/save_cancel/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/save_existing/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/save_existing_with_write/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/save_existing_with_write/test_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/save_new/test.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/save_new_with_write/test_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system/test_util.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
benwells
Not sure if this is a good idea or not, but now is the time ...
8 years, 3 months ago (2012-09-14 05:55:37 UTC) #1
Mihai Parparita -not on Chrome
LGTM chrome/common/extensions/docs/server2/templates/articles/app_storage.html would need to be updated too. http://codereview.chromium.org/10914284/diff/5002/chrome/renderer/resources/extensions/file_system_custom_bindings.js File chrome/renderer/resources/extensions/file_system_custom_bindings.js (right): http://codereview.chromium.org/10914284/diff/5002/chrome/renderer/resources/extensions/file_system_custom_bindings.js#newcode53 chrome/renderer/resources/extensions/file_system_custom_bindings.js:53: chrome.fileSystem.getWritableFileEntry ...
8 years, 3 months ago (2012-09-14 06:01:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10914284/5006
8 years, 3 months ago (2012-09-14 07:47:10 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-14 09:31:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10914284/16001
8 years, 3 months ago (2012-09-14 11:28:33 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-14 13:35:40 UTC) #6 
Change committed as 156795

Powered by Google App Engine
This is Rietveld 408576698