Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/renderer/resources/extensions/file_system_custom_bindings.js

Issue 10914284: Rename chrome.fileSystem apis to be expandable to directories if we wish. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Typo Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/file_system_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/file_system_custom_bindings.js b/chrome/renderer/resources/extensions/file_system_custom_bindings.js
index 0f2b9f4e234e4f4d480352a5ef163548145586c7..bcd1c123c55f43c52255b00cd5968af3f2f9d865 100644
--- a/chrome/renderer/resources/extensions/file_system_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/file_system_custom_bindings.js
@@ -19,7 +19,7 @@ chromeHidden.registerCustomHook('fileSystem', function(bindingsAPI) {
return [fileSystemName, relativePath, callback];
});
}
- ['getDisplayPath', 'getWritableFileEntry', 'isWritableFileEntry']
+ ['getDisplayPath', 'getWritableEntry', 'isWritableEntry']
.forEach(bindFileEntryFunction);
function bindFileEntryCallback(functionName) {
@@ -47,5 +47,24 @@ chromeHidden.registerCustomHook('fileSystem', function(bindingsAPI) {
}
});
}
- ['getWritableFileEntry', 'chooseFile'].forEach(bindFileEntryCallback);
+ ['getWritableEntry', 'chooseEntry'].forEach(bindFileEntryCallback);
+
+ // TODO(benwells): Remove these deprecated versions of the functions.
+ chrome.fileSystem.getWritableFileEntry = function() {
+ console.log("chrome.fileSystem.getWritableFileEntry is deprecated");
+ console.log("Please use chrome.fileSystem.getWritableEntry instead");
+ chrome.fileSystem.getWritableEntry.apply(this, arguments);
+ };
+
+ chrome.fileSystem.isWritableFileEntry = function() {
+ console.log("chrome.fileSystem.isWritableFileEntry is deprecated");
+ console.log("Please use chrome.fileSystem.isWritableEntry instead");
+ chrome.fileSystem.isWritableEntry.apply(this, arguments);
+ };
+
+ chrome.fileSystem.chooseFile = function() {
+ console.log("chrome.fileSystem.chooseFile is deprecated");
+ console.log("Please use chrome.fileSystem.chooseEntry instead");
+ chrome.fileSystem.chooseEntry.apply(this, arguments);
+ };
});

Powered by Google App Engine
This is Rietveld 408576698