Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 10914207: Moving from from using WebFrame::name to WebFrame::uniqueName (Closed)

Created:
8 years, 3 months ago by nasko
Modified:
8 years, 3 months ago
Reviewers:
tony, Charlie Reis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org
Visibility:
Public.

Description

Moving from from using WebFrame::name to WebFrame::uniqueName BUG=145099 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/shell/webkit_test_runner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nasko
Adding creis@ for content and tony@ for webkit OWNERS review. This is a CL to ...
8 years, 3 months ago (2012-09-12 19:38:57 UTC) #1
tony
LGTM
8 years, 3 months ago (2012-09-12 19:39:39 UTC) #2
Charlie Reis
LGTM
8 years, 3 months ago (2012-09-12 19:53:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/10914207/1
8 years, 3 months ago (2012-09-13 15:02:37 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 17:06:30 UTC) #5
Change committed as 156568

Powered by Google App Engine
This is Rietveld 408576698