Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: content/shell/webkit_test_runner.cc

Issue 10914207: Moving from from using WebFrame::name to WebFrame::uniqueName (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/tools/test_shell/test_webview_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/webkit_test_runner.cc
diff --git a/content/shell/webkit_test_runner.cc b/content/shell/webkit_test_runner.cc
index 9862911330d469f47ac9a1fa672077078f6045e1..9970b398bba6c1cf18748abb51da15f970dc99ca 100644
--- a/content/shell/webkit_test_runner.cc
+++ b/content/shell/webkit_test_runner.cc
@@ -55,7 +55,7 @@ std::string DumpFramesAsText(WebFrame* frame, bool printing, bool recursive) {
// Add header for all but the main frame. Skip emtpy frames.
if (frame->parent() && !frame->document().documentElement().isNull()) {
result.append("\n--------\nFrame: '");
- result.append(frame->name().utf8().data());
+ result.append(frame->uniqueName().utf8().data());
result.append("'\n--------\n");
}
@@ -79,7 +79,7 @@ std::string DumpFrameScrollPosition(WebFrame* frame, bool recursive) {
if (offset.width > 0 || offset.height > 0) {
if (frame->parent()) {
result.append(
- base::StringPrintf("frame '%s' ", frame->name().utf8().data()));
+ base::StringPrintf("frame '%s' ", frame->uniqueName().utf8().data()));
}
result.append(
base::StringPrintf("scrolled to %d,%d\n", offset.width, offset.height));
« no previous file with comments | « no previous file | webkit/tools/test_shell/test_webview_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698