Chromium Code Reviews| Index: webkit/chromeos/fileapi/cros_mount_point_provider.cc |
| diff --git a/webkit/chromeos/fileapi/cros_mount_point_provider.cc b/webkit/chromeos/fileapi/cros_mount_point_provider.cc |
| index 79642c4164597b2424345dedc015d8662e952e6d..067b310a5ef04ef8f600cd00a89f8f5fb2498b69 100644 |
| --- a/webkit/chromeos/fileapi/cros_mount_point_provider.cc |
| +++ b/webkit/chromeos/fileapi/cros_mount_point_provider.cc |
| @@ -218,15 +218,17 @@ FilePath CrosMountPointProvider::GetPathForPermissionsCheck( |
| fileapi::FileSystemOperation* CrosMountPointProvider::CreateFileSystemOperation( |
| const fileapi::FileSystemURL& url, |
| - fileapi::FileSystemContext* context) const { |
| + fileapi::FileSystemContext* context, |
| + base::PlatformFileError* error_code) const { |
| if (url.type() == fileapi::kFileSystemTypeDrive) { |
| base::AutoLock locker(mount_point_map_lock_); |
| RemoteProxyMap::const_iterator found = remote_proxy_map_.find( |
| url.filesystem_id()); |
| - // TODO(kinuko): we should handle not-found case gracefully. |
| - // http://crbug.com/141617 |
| if (found != remote_proxy_map_.end()) { |
| return new chromeos::RemoteFileSystemOperation(found->second); |
| + } else { |
|
kinuko
2012/09/11 05:01:39
nit: no need of else (since we're returning in if)
kmadhusu
2012/09/11 15:11:42
You had a TODO to handle the not-found case gracef
|
| + *error_code = base::PLATFORM_FILE_ERROR_NOT_FOUND; |
| + return NULL; |
| } |
| } |