Added PlatformFileError param to FileSystemMountPointProvider::CreateFileSystemOperation function.

webkit/chromeos/fileapi/cros_mount_point_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/chromeos/fileapi/cros_mount_point_provider.h"
 
 #include "base/chromeos/chromeos_version.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
@@ skipping 200 matching lines @@
   return local_file_util_.get();
 }
 
 FilePath CrosMountPointProvider::GetPathForPermissionsCheck(
     const FilePath& virtual_path) const {
   return virtual_path;
 }
 
 fileapi::FileSystemOperation* CrosMountPointProvider::CreateFileSystemOperation(
     const fileapi::FileSystemURL& url,
-    fileapi::FileSystemContext* context) const {
+    fileapi::FileSystemContext* context,
+    base::PlatformFileError* error_code) const {
   if (url.type() == fileapi::kFileSystemTypeDrive) {
     base::AutoLock locker(mount_point_map_lock_);
     RemoteProxyMap::const_iterator found = remote_proxy_map_.find(
         url.filesystem_id());
-    // TODO(kinuko): we should handle not-found case gracefully.
-    // http://crbug.com/141617
     if (found != remote_proxy_map_.end()) {
       return new chromeos::RemoteFileSystemOperation(found->second);
+    } else {

[kinuko, 2012/09/11 05:01:39]

nit: no need of else (since we're returning in if)

[kmadhusu, 2012/09/11 15:11:42]

You had a TODO to handle the not-found case gracefully. Else part corresponds to
that TODO. I am going to commit with this change. If you still feel that this
else part is not required, I can remove it in a separate CL.

+      *error_code = base::PLATFORM_FILE_ERROR_NOT_FOUND;
+      return NULL;
     }
   }
 
   DCHECK(url.type() == fileapi::kFileSystemTypeNativeLocal);
   scoped_ptr<fileapi::FileSystemOperationContext> operation_context(
       new fileapi::FileSystemOperationContext(context));
   return new fileapi::LocalFileSystemOperation(context,
                                                operation_context.Pass());
 }
 
@@ skipping 39 matching lines @@
   }
   return iter->first.DirName().AppendRelativePath(
       filesystem_path, virtual_path);
 }
 
 fileapi::IsolatedContext* CrosMountPointProvider::isolated_context() const {
   return fileapi::IsolatedContext::GetInstance();
 }
 
 }  // namespace chromeos