Fix URLFetcher leaks in ChromeToMobileService

Fix URLFetcher leaks in ChromeToMobileService

sync_integration_tests are failing due to URLFetcher leaks in ChromeToMobileService.

This patch fixes the leaks by using scoped_ptrs instead of raw pointers.

TBR=msw@chromium.org
BUG=146826
TEST=sync_integration_tests

[Raghu Simha, 2012-09-07 01:39:33]

msw@, please review.

[Hironori Bono, 2012-09-07 02:00:37]

LGTM.

[msw, 2012-09-07 02:01:30]

Thanks for finding and attempting to fix this issue!

http://codereview.chromium.org/10914136/diff/2001/chrome/browser/chrome_to_mo...
File chrome/browser/chrome_to_mobile_service.cc (right):

http://codereview.chromium.org/10914136/diff/2001/chrome/browser/chrome_to_mo...
chrome/browser/chrome_to_mobile_service.cc:255:
submit_url_.reset(CreateRequest());
This won't work, as there may be multiple simultaneous send requests. Can we
change |request_observer_map_| to be an std::map<scoped_ptr<net::URLFetcher>,
base::WeakPtr<Observer> > and let the requests be owned by the map?

http://codereview.chromium.org/10914136/diff/2001/chrome/browser/chrome_to_mo...
chrome/browser/chrome_to_mobile_service.cc:514:
search_request_.reset(net::URLFetcher::Create(
Similarly, this won't work for multiple simultaneous search requests. Could we
instead maintain a ScopedVector<URLFetcher> for the search requests?

[commit-bot: I haz the power, 2012-09-07 02:02:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsimha@chromium.org/10914136/2001

[msw, 2012-09-07 02:02:41]

On 2012/09/07 02:02:06, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/rsimha%40chromium.org/10914136/2001

I unchecked the CQ... this patch is not acceptable.

[Raghu Simha, 2012-09-07 02:05:25]

On 2012/09/07 02:02:41, msw wrote:
> I unchecked the CQ... this patch is not acceptable.

Thanks! Looking at your feedback.

[msw, 2012-09-07 15:26:02]

I'm planning to fix the leak in http://codereview.chromium.org/10918119/
I'll take the bug from you, and you can abandon this CL; but thanks for looking!