Fix FindSharedFunctionInfoInScript to not optimize.

Fix FindSharedFunctionInfoInScript to not optimize.

This prevents a corner case in FindSharedFunctionInfoInScript that would cause
functions to be optimized because an intermittent GC would clear the flag
indicating whether breakpoints are present. Above method was also moved into the
Debug class because it is only used by the debugger.

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=12428

[Michael Starzinger, 2012-09-03 13:36:53]

https://chromiumcodereview.appspot.com/10914065/diff/1/src/debug.cc
File src/debug.cc (right):

https://chromiumcodereview.appspot.com/10914065/diff/1/src/debug.cc#newcode2182
src/debug.cc:2182: has_break_points_ = true;
These are the only two lines I changed in this function, the rest was just moved
over from runtime.cc into this file.

[Toon Verwaest, 2012-09-03 13:44:22]

LGTM with one nit.

https://chromiumcodereview.appspot.com/10914065/diff/1/src/debug.cc
File src/debug.cc (right):

https://chromiumcodereview.appspot.com/10914065/diff/1/src/debug.cc#newcode1176
src/debug.cc:1176: // implicitly by Debug::FindSharedFunctionInfoInScript.
Just move PrepareForBreakPoints() here from FindSharedFunctionInfoInScript so no
explanation is needed.

[Michael Starzinger, 2012-09-03 14:08:49]

Addressed comments. Landing.

https://chromiumcodereview.appspot.com/10914065/diff/1/src/debug.cc
File src/debug.cc (right):

https://chromiumcodereview.appspot.com/10914065/diff/1/src/debug.cc#newcode1176
src/debug.cc:1176: // implicitly by Debug::FindSharedFunctionInfoInScript.
On 2012/09/03 13:44:22, Toon Verwaest wrote:
> Just move PrepareForBreakPoints() here from FindSharedFunctionInfoInScript so
no
> explanation is needed.

Done.