src/compiler.cc - Issue 10914065: Fix FindSharedFunctionInfoInScript to not optimize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 10914065: Fix FindSharedFunctionInfoInScript to not optimize. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments by Toon Verwaest. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index 6153f3a44abc9b68b4d04b623b98789c0d79071c..e4a30dbbcedf92b5134755fd3dec41f100f49406 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -936,7 +936,7 @@ Handle<SharedFunctionInfo> Compiler::BuildFunctionInfo(FunctionLiteral* literal,

// If the debugger requests compilation for break points, we cannot be

// aggressive about lazy compilation, because it might trigger compilation

// of functions without an outer context when setting a breakpoint through

- // Runtime::FindSharedFunctionInfoInScript.

+ // Debug::FindSharedFunctionInfoInScript.

bool allow_lazy_without_ctx = literal->AllowsLazyCompilationWithoutContext();

bool allow_lazy = literal->AllowsLazyCompilation() &&

!LiveEditFunctionTracker::IsActive(info.isolate()) &&

« no previous file with comments | « no previous file | src/debug.h » ('j') | no next file with comments »