Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 10914029: Use a separate thread for audio capturing and encoding. (Closed)

Created:
8 years, 3 months ago by Sergey Ulanov
Modified:
8 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Use a separate thread for audio capturing and encoding. Previously we were using the same thread for capturing video frames and audio capturing and encoding. It seems suboptimal as we don't want to block screen capturer on audio encoding. BUG=123046, 145891 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154597

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -26 lines) Patch
M remoting/host/audio_scheduler.h View 1 2 2 chunks +10 lines, -18 lines 0 comments Download
M remoting/host/audio_scheduler.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_host_context.h View 2 chunks +6 lines, -0 lines 0 comments Download
M remoting/host/chromoting_host_context.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
8 years, 3 months ago (2012-08-31 01:54:22 UTC) #1
Wez
LGTM w/ comment nits http://codereview.chromium.org/10914029/diff/1/remoting/host/audio_scheduler.h File remoting/host/audio_scheduler.h (right): http://codereview.chromium.org/10914029/diff/1/remoting/host/audio_scheduler.h#newcode28 remoting/host/audio_scheduler.h:28: // encoding it and then ...
8 years, 3 months ago (2012-08-31 04:44:51 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/10914029/diff/1/remoting/host/audio_scheduler.h File remoting/host/audio_scheduler.h (right): http://codereview.chromium.org/10914029/diff/1/remoting/host/audio_scheduler.h#newcode28 remoting/host/audio_scheduler.h:28: // encoding it and then sending encoded data over ...
8 years, 3 months ago (2012-08-31 20:18:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10914029/7001
8 years, 3 months ago (2012-08-31 23:32:25 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-01 03:55:48 UTC) #5
Change committed as 154597

Powered by Google App Engine
This is Rietveld 408576698