SPDY proxy authentication support.

chrome/browser/password_manager/password_manager_delegate_impl.cc

Index: chrome/browser/password_manager/password_manager_delegate_impl.cc
diff --git a/chrome/browser/password_manager/password_manager_delegate_impl.cc b/chrome/browser/password_manager/password_manager_delegate_impl.cc
index 6360be4dd21e0fd1058a7a71b22aa46586687437..76b273890bf8e5e686f56b15d2e865b502784142 100644
--- a/chrome/browser/password_manager/password_manager_delegate_impl.cc
+++ b/chrome/browser/password_manager/password_manager_delegate_impl.cc
@@ -150,6 +150,12 @@ void PasswordManagerDelegateImpl::AddSavePasswordInfoBarIfPermitted(
   }
 #endif
 
+  // Don't show the password manager infobar if this form corresponds to
+  // SpdyProxy authentication, as indicated by the realm.

[Ilya Sherman, 2012/09/24 23:47:25]

What is the user action that would reach this code?  It rather seems like this
flow should be pre-empted prior to when we're about to show an infobar...

[Michael Piatek, 2012/09/25 19:28:14]

This is designed to suppress the 'remember the password for this website?'
prompt, which is inappropriate for this authentication type.

[Ilya Sherman, 2012/09/25 22:31:07]

Can you describe more what "this authentication type" is?  I still don't
understand what user action triggers this code...

[Michael Piatek, 2012/09/26 23:08:34]

moved this to password_manager.cc per discussion

+  if (form_to_save->realm().find("/SpdyProxy") != std::string::npos) {

[Ilya Sherman, 2012/09/24 23:47:25]

nit: Please define a constant for this string.  Also, can we do a full string
match, rather than a substring search?

[Michael Piatek, 2012/09/25 19:28:14]

Done. (Checked for a suffix match, since the full string contains this preceded
by the origin.)

+    return;
+  }

[Ilya Sherman, 2012/09/24 23:47:25]

nit: No need for curly braces.

[Michael Piatek, 2012/09/25 19:28:14]

Done.

+
   tab_contents_->infobar_tab_helper()->AddInfoBar(
       new SavePasswordInfoBarDelegate(
           tab_contents_->infobar_tab_helper(), form_to_save));