SPDY proxy authentication support.

chrome/browser/password_manager/password_manager_delegate_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_manager_delegate_impl.h"
 
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/api/infobars/confirm_infobar_delegate.h"
@@ skipping 132 matching lines @@
   // TODO(mathp): Checking only against associated_username() causes a bug
   // referenced here: crbug.com/133275
   if ((realm == GURL(GaiaUrls::GetInstance()->gaia_login_form_realm()) ||
       realm == GURL("https://www.google.com/")) &&
       OneClickSigninHelper::CanOffer(tab_contents_->web_contents(),
           UTF16ToUTF8(form_to_save->associated_username()), true)) {
     return;
   }
 #endif
 
+  // Don't show the password manager infobar if this form corresponds to
+  // SpdyProxy authentication, as indicated by the realm.

[Ilya Sherman, 2012/09/24 23:47:25]

What is the user action that would reach this code?  It rather seems like this
flow should be pre-empted prior to when we're about to show an infobar...

[Michael Piatek, 2012/09/25 19:28:14]

This is designed to suppress the 'remember the password for this website?'
prompt, which is inappropriate for this authentication type.

[Ilya Sherman, 2012/09/25 22:31:07]

Can you describe more what "this authentication type" is?  I still don't
understand what user action triggers this code...

[Michael Piatek, 2012/09/26 23:08:34]

moved this to password_manager.cc per discussion

+  if (form_to_save->realm().find("/SpdyProxy") != std::string::npos) {

[Ilya Sherman, 2012/09/24 23:47:25]

nit: Please define a constant for this string.  Also, can we do a full string
match, rather than a substring search?

[Michael Piatek, 2012/09/25 19:28:14]

Done. (Checked for a suffix match, since the full string contains this preceded
by the origin.)

+    return;
+  }

[Ilya Sherman, 2012/09/24 23:47:25]

nit: No need for curly braces.

[Michael Piatek, 2012/09/25 19:28:14]

Done.

+
   tab_contents_->infobar_tab_helper()->AddInfoBar(
       new SavePasswordInfoBarDelegate(
           tab_contents_->infobar_tab_helper(), form_to_save));
 }
 
 Profile* PasswordManagerDelegateImpl::GetProfile() {
   return tab_contents_->profile();
 }
 
 bool PasswordManagerDelegateImpl::DidLastPageLoadEncounterSSLErrors() {
   content::NavigationEntry* entry =
       tab_contents_->web_contents()->GetController().GetActiveEntry();
   if (!entry) {
     NOTREACHED();
     return false;
   }
 
   return net::IsCertStatusError(entry->GetSSL().cert_status);
 }