Issue 10913096: Minor code cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10913096: Minor code cleanup (Closed)

Created:
8 years, 3 months ago by danrubel

Modified:
8 years, 3 months ago

Reviewers:
Bill Hesse, Mads Ager (google), Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Minor code cleanup Committed in r11921, with other changes, as CL https://chromiumcodereview.appspot.com/10911120/

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -27 lines)			Patch
M	runtime/bin/http.dart	View		1 chunk	+23 lines, -23 lines	0 comments	Download
M	runtime/bin/http_parser.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/bin/websocket_impl.dart	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

8 years, 3 months ago (2012-09-06 07:32:29 UTC) #3

On 2012/09/06 06:14:15, Mads Ager wrote:
> LGTM, thanks!

I landed this together with some additional changes and a test,
https://chromiumcodereview.appspot.com/10911120/.

Expand Messages | Collapse Messages